Closed (fixed)
Project:
Plupload integration
Version:
2.0.x-dev
Component:
Documentation
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2022 at 11:34 UTC
Updated:
19 Jan 2023 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
nitapawar commentedComment #4
nitapawar commentedComment #5
nitapawar commentedComment #6
nitapawar commentedComment #7
Nila Hyalij commentedPatch looks good for me.
Moving to RTBC.
Comment #8
avpadernoRenaming a file isn't sufficient. Either the file is changed to use Markdown markup, or the file extension is left as it is, since the Drupal coding standards say:
Furthermore, the Drupal coding standards for the Markdown markup are still discussed.
Comment #9
dharmeshbarot commentedplease check this.
Comment #10
avpadernoThose empty lines aren't necessary.
Code should be formatted as code.
Comment #11
avpadernoThe patch needs also to remove the README.,txt file, since that is replaced by the README.md file.
Comment #12
dharmeshbarot commentedFirst use git rm README.txt
and then use this patch.
Comment #13
avpadernoActually, it's the patch that needs to remove the README.txt file.
Comment #14
dharmeshbarot commentedNow check
Comment #15
karanpagare commentedFacing this error while applying patch #14
Comment #16
avpadernoPatch in comment #14 is altering a file that doesn't exist in the project repository, and it still doesn't remove the README.txt file.
Comment #17
anchal_gupta commentedRename the file
Comment #18
avpadernoSimply renaming a file isn't sufficient. A README.md content needs to be Markdown markup.
Comment #19
dharmeshbarot commentedI think this might work.
Comment #20
karanpagare commentedPatch #19 applied successfully and replaces README.txt with README.md
Comment #21
Nila Hyalij commentedI have tested patch #19.
It's working fine.
Comment #22
budalokko commentedThanks for the work been done.
Please use some kind of markdown viewer to check the final result.
Comment #23
budalokko commentedHope the attached image clarifies my previous comment.
Comment #25
ressaI agree @budalokko, people ought to preview the actual rendered result, before asking for a review. It is actually quite easy, since the Gitlab integration provides this, simply by clicking the branch name 3317550-need-to-replace.
Comment #27
Manoj Raj.R commentedAdded the some integration of the Markdown format.
Comment #28
Sonal Gyanani commentedThanks, README.md file looks good.
Moving it to RTBC
Comment #30
budalokko commentedCommitted !! The final result looks lovely. Thanks all who participated.
Comment #31
ressaThanks @budalokko! Perhaps change default branch to 2.x? Right now, you get the 1.x branch with README.txt: https://git.drupalcode.org/project/plupload/
Comment #32
budalokko commentedNice catch. Changed. Thank you !!
Comment #33
ressaPerfect, thanks for maintaining the module. Have a nice day.