Problem/Motivation
User wants to see group menus as part of the site navigation.
Steps to reproduce
Proposed resolution
Allow group menus to have a core menu item as parent. To facilitate this, add a menu_link_reference field item and widget.
Remaining tasks
User interface changes
API changes
The menu name is no longer hardwired but needs to be called with $group_content_menu->getMenuName() and also to render a group menu tree , the storage handler has a loadMenuTree method.
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3317493_9_12.txt | 5.1 KB | ghost of drupal past |
| #12 | 3317493_12.patch | 62.64 KB | ghost of drupal past |
Comments
Comment #2
ghost of drupal pastComment #3
ghost of drupal pastComment #5
ghost of drupal pastComment #7
ghost of drupal pastComment #9
ghost of drupal pastComment #10
ghost of drupal pastComment #11
heddnGroup
delete
^9 || ^10
Please!
visibility, public or private.
$this-t()
$this-t()
$this-t()
return array_map(static fn (EntityInterface $e) => $e->label(), $menus);
A little more details on
$dovariable would help. from its name I would assume its a boolean, but then it isn't type hinted. Hmm, actually, the param arguments are all a little out of sync.Class test name should rename.
Variable naming a bit off.
Comment #12
ghost of drupal pastThanks for the review, this is done. I haven't renamed the test , it is testing the submenu functionality after all.
Comment #13
heddnComment #16
ghost of drupal pastThanks!
Comment #17
heddn