Keys could be managed with Drush state commands. The implementation seems to be trivial.

CommentFileSizeAuthor
#4 key_state_provider-3317490-4.patch3.15 KBchi
#2 key_state_provider-3317490-2.patch3.15 KBchi

Issue fork key-3317490

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chi created an issue. See original summary.

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new key_state_provider-3317490-2.patch3.15 KB
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs review » Needs work

Thanks for the patch. I just have one comment:

+++ b/src/Plugin/KeyProvider/StateKeyProvider.php
@@ -0,0 +1,97 @@
+ * A key provider that allows a key to be stored in an environment variable.

This comment needs to be updated.

chi’s picture

chi commented
Status: Needs work » Needs review
StatusFileSize
new key_state_provider-3317490-4.patch3.15 KB

rajeshreeputra made their first commit to this issue’s fork.

rajeshreeputra opened merge request !42

chandu7929’s picture

chandu7929 commented
Status: Needs review » Needs work
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review

Please review.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Needs work

Requested some changes in the MR. One question here, should this provider function similar like the Environment Key provider, meaning should only read values from the state rather than saving, reading and deleting value as well from the state ?

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review

Incorporated feedback, hence setting to needs review.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Reviewed & tested by the community

Reviewed changes, looks good to me. Hence, RTBC.

  • rlhawk committed b390af80 on 8.x-1.x authored by rajeshreeputra 
    Issue #3317490 by rajeshreeputra, chi, vishalkhode, chandu7929: Add key...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

@rlhawk this need to cherry pick into 4.0.x branch as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

japerry’s picture

japerry
Location KOMK
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Closed (fixed) » Patch (to be ported)

Since we just worked on this, going to re-open this issue to port to 2.0