The goal of this module is to provide the ability to navigate forward and backward through a web form using the Webform Progress tracker (aka wizard progress bar) supplied by the webform module on multi-page web forms. It also allows for the ability to bypass validation when the user presses the "next" button as they navigate through the form.

Project link

https://www.drupal.org/project/webformnavigation

Three Issues I've Reviewed

  1. [1.1.x] External Link Update
  2. [8.x-1.x] Holy
  3. [1.0.x] Preload Font

Comments

rymcveigh created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Disclosure: rymcveigh is a colleague of mine at work.

Automated Review

I didn't run phpcs but I know that Ryan did run it recently since this commit addressed the feedback from the tool.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: does not strictly follow the guidelines for in-project documentation and/or the README Template. However, the README is helpful and well organized
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements. We hired an auditor experienced with Drupal to help review the module last year, though it has changed since then.
Coding style & Drupal API usage
  1. I did not identify any issues in my review with coding style nor Drupal API usage.

This review uses the Project Application Review Template.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

I didn't see anything wrong in the code.
The code in WebformNavigationHandler::create() is different from the code expected from that method, but that is necessary when extending WebformHandlerBase, which doesn't follow the usual pattern seen on Drupal core classes.
Some methods seem to contain only debugging code, but the purpose of the module is also logging when some methods are called (which means that isn't code to debug the module).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks for moving this along, Apaderno!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.