Problem/Motivation

The method name getSchedulerId makes it sound like it returns an ID, but the docs say it returns a whole array of settings:

> * Gets scheduler array which holds info about the scheduler settings.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ultimate_cron-3317195

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: CronJob::getSchedulerId() is badly named » Fix CronJob::getSchedulerId() to return ID
Issue tags: +Novice

Considering that getLauncherId() and getLoggerId() do what you'd expect from the method name, I'd say the name is actually the only correct thing about this method. It should work like the other two and the docs updated. It also seems unused. Still a chance to do this before stable release.

tanushree gupta’s picture

tanushree gupta commented
Assigned: Unassigned » tanushree gupta

tanushree gupta opened merge request !73

tanushree gupta’s picture

tanushree gupta commented
Assigned: tanushree gupta » Unassigned
Status: Active » Needs review
rjustin’s picture

rjustin commented
Status: Needs review » Reviewed & tested by the community

+1

The merge request posted by @tanushree-gupta aligns with the success criteria documented in the issue. I believe this is good to merge in.

liam morland made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merging.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.