Forms in Drupal typically have a primary button that marks the happy flow. However the Action configuration form displays all actions with a similar weight, so the interface takes more time to scan at a glance.
Action -> Change the author of content -> Apply to selected items
Implement a primary button in Action configuration form for consistency with other Drupal forms.
The Action configuration form implements a primary button for consistency with other Drupal forms.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3317188-2.patch | 759 bytes | idebr |
| #2 | 3317188-2-after.png | 47.01 KB | idebr |
| #2 | 3317188-2-before.png | 47.02 KB | idebr |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
idebr commentedAttached patch implements a primary button in Action configuration form for consistency with other Drupal forms.
Before:
After:
Comment #5
graber commented@idebr, you removed weight of the submit button, did you have any particular reason? This'll probably break the appearance of some action config forms as the button will not be at the bottom.
Comment #6
idebr commentedI removed the weight from the actions wrapper, since form actions are always rendered at the bottom of a form.
The weight was introduced when the element was no actions wrapper. The introduction of the actions wrapper left the weight when it could have been removed in #3311031: Form actions should be of type actions
Comment #7
graber commentedAhh, good to know, thanks :)
Comment #9
graber commentedWe could've removed the above comment as well..