Problem/Motivation

PHP Deprecated: Required parameter $form_state follows optional parameter $input in video/video.field.inc on line 676

Steps to reproduce

Run drush up with PHP 8

Proposed resolution

Follow suite with core file_field_widget_value and set $form_state to optional.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3316939-3-php-8.patch653 bytesjoelpittet
#2 3316939-2-php-8.patch16.11 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3316939-2-php-8.patch16.11 KB
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3316939-3-php-8.patch653 bytes

Sorry for the patch size, I tried ignoring whitespace with the -W flag but there were just too many coding standards whitespace changes in the file.

Here's a patch version

erikaagp’s picture

erikaagp commented
Status: Needs review » Reviewed & tested by the community

It seems good to me.

  • poker10 committed ca3c69f0 on 7.x-2.x authored by joelpittet 
    Issue #3316939 by joelpittet: PHP Deprecated: Required parameter $...
poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Fixed

The approach looks reasonable, as all functions where the $form_state is passed next actually expects an array.

Committed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.