Problem/Motivation

PHP Deprecated: Required parameter $form_state follows optional parameter $input in /var/www/html/public/sites/all/modules/imagefield_crop/imagefield_crop.module on line 782

Steps to reproduce

Run drush up with PHP 8.0

Proposed resolution

Make $form_state optional too as core does here in file_field_widget_value

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3316934-2-php-8.patch588 bytesjoelpittet

Issue fork imagefield_crop-3316934

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3316934-2-php-8.patch588 bytes

vinmassaro made their first commit to this issue’s fork.

vinmassaro opened merge request !1

vinmassaro’s picture

vinmassaro commented
Status: Needs review » Reviewed & tested by the community

The patch in #2 works but I rerolled it as a MR because it would not apply to 7.x-2.x. Thanks!

vinmassaro’s picture

vinmassaro commented
ram4nd’s picture

ram4nd commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.