Problem/Motivation

After Updating to 1.0.1 it takes a good 3 minutes to load the `/admin/reports/audit-trail` route due to our audit table being extremely large, and I think the pagination is no longer working causing the HTML table produced to be thousands of '<tr>` the browser can barely handle it.

Steps to reproduce

Have a very large audit trail, visit `/admin/reports/audit-trail` I don't see any pagination and all records are put into a single table.

I think this code change broke pagination
Screenshot

CommentFileSizeAuthor
#8 3316835-latest-release-breaks-pagination.patch1.28 KBeason xu
changes_broke_pagination.png55.79 KBnicholass

Issue fork admin_audit_trail-3316835

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

NicholasS created an issue. See original summary.

nicholass’s picture

nicholass
Primary language English
Location FL
commented
Issue summary: View changes

NicholasS opened merge request !9

nicholass’s picture

nicholass
Primary language English
Location FL
commented
Status: Active » Needs review
nicholass’s picture

nicholass
Primary language English
Location FL
commented
Issue summary: View changes
sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
Status: Needs review » Reviewed & tested by the community

I have tested MR with these results:
* Diff file can be applied cleanly to admin_audit_trail 1.0.1 via composer.

Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/admin_audit_trail (1.0.1): Extracting archive
  - Applying patches for drupal/admin_audit_trail
    https://git.drupalcode.org/project/admin_audit_trail/-/merge_requests/9.diff (Latest Release Breaks Pagination - https://www.drupal.org/project/admin_audit_trail/issues/3316835)

* Before applying MR the diff file, admin_audit_trail displays all 300 rows in one page
* After applying the MR diff file, admin_audit_trail now displays the correct paginated results in 15 pages.

yovince’s picture

yovince
Location Melbourne
commented

tested MR, looks good to me.

eason xu’s picture

eason xu commented
StatusFileSize
new 3316835-latest-release-breaks-pagination.patch1.28 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Critical
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Latest Release Breaks Pagination » Fix pagination breaks in latest release which was not applied with Drupal ~0
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fix pagination breaks in latest release which was not applied with Drupal ~0 » Fix pagination breaks in latest release which was not applied with Drupal ~10
rajab natshah’s picture

rajab natshah
he/him
commented

Faced the same issue in #3330106: Fix not applied pagination
Committing the better fix by Nicholas.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fix pagination breaks in latest release which was not applied with Drupal ~10 » Fix pagination and sorting for latest release which was not applied with Drupal ~10

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Reviewed & tested by the community » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: +admin_audit_trail-1.0.2
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released admin_audit_trail-1.0.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.