Problem/Motivation
Right now, ComposerSettingsValidator invokes the Composer API to get the secure-http config value. Therefore, it relies on the presence of the Composer API, which is something we're hoping to move away from.
Proposed resolution
Extract the value of the secure-http config value by running composer config secure-http and parsing the output.
Issue fork automatic_updates-3316668
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
phenaproximaComment #6
tedbowComment #7
tedbowComment #8
tedbowComment #9
tedbowComment #10
traviscarden commentedComment #11
wim leers@tedbow @TravisCarden On November 14, this was assigned to Travis for <4 hours. Without context as to why it was assigned to him, nor why it was unassigned. Can we please get clarity on this? 🙏
Comment #12
tedbow#11 not sure why now 😔
There are no MR comments awaiting replies from @TravisCarden. He made some suggestions on the issue but I think others could implement this.
Comment #13
wim leers#12: k, thanks!
I think this qualifies as a security improvement because it makes it less likely that PM/AU will reach the wrong conclusion if
composer's configuration structure changes in the future:composer config secure-httpSHOULD provide BC.Comment #14
tedbowComment #15
tedbowWe need a test on
ComposerInspectorat least. I haven't checked furtherComment #16
tedbowNot blocking on #3320792: Make build tests fail 1) more explicitly, 2) earlier when possible (failing StatusCheckEvent subscribers) but I have brought in a change from there because it makes debugging build tests easier.
Comment #17
tedbowGoing to stop working on this so I can get some of the other child issues of #3316368: Remove our runtime dependency on composer/composer: remove ComposerUtility
Anyone else can review my work and try to get these tests passing
Comment #18
tedbowComment #19
tedbowI still trying to get the test to pass
Comment #20
tedbowTests are passing. I brought in some changes from 3320792-build-status-report that need to be removed. Also add a couple other comments on the MR
Comment #21
yash.rode commentedComment #22
yash.rode commentedComment #23
wim leers12 remarks in MR, ~50% of which are nits. But there definitely are more tests to be written still! 😊
Comment #24
yash.rode commentedComment #25
wim leersAlmost there!
for a bit of missing test coverage plus a formatting nit.
I left two questions on the merge request for @tedbow that you don't have to address, @yash.rode.
Comment #26
yash.rode commentedComment #27
wim leersFor some reason your
boo-farmade me laugh out loud 🤣👍RTBC — with two questions for @tedbow 😊
Comment #28
tedbowBecause of #3337697: Custom commands fail for 7.4 I am going to run tests on 9.5 without code checks assuming if code checks are ok on 10.1 they are will be ok on 9.5. Also we aren't merging into 9.5 core
Comment #30
tedbow🎉