Problem/Motivation

Right now if cron updates are enable(once we flip the feature flag), if you sites start fail the status checks there would be messages in the admin UI displayed from \Drupal\automatic_updates\Validation\AdminReadinessMessages::displayAdminPageMessages()
but if the admin doesn't come to the site often they would not alert via email. This means they could miss a critical security update they expected to be applied.

Proposed resolution

Send an email when cron updates go into state where there are likely not succeed anymore.
This would mean any time Status Checks start to flag errors or warning we should send an email.

Remaining tasks

Determine the exact behavior

Issue fork automatic_updates-3316611

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Send an email when the site stops passing readiness checks » If unattended updates are enabled send an email when the site stops passing readiness checks

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

@tedbow and I talked about this and agreed on an architecture.

First, we only send emails if cron updates are enabled at all.
Secondly, we'll add a config switch to determine if emails should be sent. If that switch is disabled, we don't email.
Then we'll add another config switch to determine the minimum severity about which we should send emails (either errors or warnings).
Then, if all these conditions are true, we'll examine the current results against the previous results. If the severity is different, AND the severity is at least the configured minimum severity, we'll email.

phenaproxima opened merge request !554

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs work
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: If unattended updates are enabled send an email when the site stops passing readiness checks » If unattended updates are enabled, send an email when readiness checks start failing
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » tedbow
Status: Needs work » Needs review

Took some doing, but I've got your feedback addressed, @tedbow. Over to you!

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Needs work
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: If unattended updates are enabled, send an email when readiness checks start failing » If unattended updates are enabled, send an email when status checks start failing
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Needs work

Looking good. Great test coverage!

Needs works for MR comments

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » phenaproxima
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +core-mvp
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » tedbow
Status: Needs work » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » phenaproxima
Status: Needs review » Needs work

I really like the new StatusCheckNotifier class!

Just few more things.

I hadn't thought before about the effect clearing the results would have the display on admin page.s

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » tedbow
Status: Needs work » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Needs work

Just 1 nit on a comment

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

🐎🎉

Thanks!

  • phenaproxima committed 0d680aa on 8.x-2.x 
    Issue #3316611 by phenaproxima, tedbow: If unattended updates are...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: tedbow » Unassigned
Status: Reviewed & tested by the community » Fixed

At last! Merged into 8.x-2.x.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3314137: Make Automatic Updates Drupal 10-compatible

The test coverage here had some pretty significant issues that were masked by unrelated code: #3314137-21: Make Automatic Updates Drupal 10-compatible.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.