Problem/Motivation

Getting a 500 error when accessing /admin/modules with the following PHP message:
Fatal error: Declaration of Drupal\views_bulk_edit\Form\BulkEditFormTrait::submitConfigurationForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\views_bulk_operations\Action\ViewsBulkOperationsActionBase::submitConfigurationForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state): void in /app/htdocs/modules/contrib/views_bulk_edit/src/Plugin/Action/ModifyEntityValues.php on line 380

Steps to reproduce

  • Install version 2.7 of views_bulk_edit with version 4.2.1 of views_bulk_operations
  • Access /admin/modules
  • PHP Fatal Error is displayed

Proposed resolution

In src/Form/BulkEditFormTrait.php, change

public function submitConfigurationForm(array &$form, FormStateInterface $form_state) {

to

public function submitConfigurationForm(array &$form, FormStateInterface $form_state) : void {

Issue fork views_bulk_edit-3316334

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roryfsoton created an issue. See original summary.

roryfsoton opened merge request !14

roryfsoton’s picture

roryfsoton commented

Have submitted the above change as an MR - I'm new to Drupal contributions so I hope this is alright! :)

pookmish’s picture

pookmish commented
Priority: Normal » Critical
Status: Active » Reviewed & tested by the community

The MR applies cleanly and corrects the issue.

maxstarkenburg’s picture

maxstarkenburg
he/him
commented

Thanks, @roryfsoton. I was a bit taken aback that updating VBO had this effect. Seconding @pookmish, the diff from your MR works well for a patch to resolve the WSOD for me. Much appreciated.

  • Graber committed 7268c84 on 8.x-2.x 
    Issue #3316334 by roryfsoton, pookmish, maxstarkenburg: Interface...
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Yeah, it's the second time coding standards fixes in VBO break backwards compatibility here. Thanks for the MR, committed, will release together with D10 readiness a bit later today.

Graber closed merge request !14

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.