Problem/Motivation
Replace README.txt with README.md
Steps to reproduce
Need README.md format
Proposed resolution
Fallow this format
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
Issue fork autologout-3315952
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
immaculatexavier commentedCommitted in accordance to the proposed resolution
Comment #5
immaculatexavier commentedComment #6
immaculatexavier commentedCommitted that adheres to Drupal standards.
Comment #7
dineshreddymathuku commentedHI #5 thanks for your Responce
Comment #8
damienmckennaThis is pretty good, but the "Contents of this file" section is not necessary.
Comment #11
immaculatexavier commentedCommitted in accordance to #8
Comment #12
gowthamrajkrishnasamy commentedHi Damien,
Updated as per your suggestion
Comment #13
dineshreddymathuku commentedhi all Updated README.md file As per Markdown format
thanks
Comment #15
Manoj Raj.R commentedCommitted according to the proposed solution.
As per #8.
Please review it
Comment #16
Pracheth commentedReviewed #14(latest merge request updated 10 November 2022 ) by @Manoj Raj.R, README.md looks good to me and adheres to Drupal markdown practices.
Also, reflects the changes suggested in #8.
Changing the status to Reviewed and Tested by Community.
Comment #17
Manoj Raj.R commentedUpdated according to the latest information from the Drupal ORG.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
Comment #19
deaom commentedThe MR #27 can be closed as all the changes were happening in the MR #26. I added a FAQ section based on the #3363875: Autologout disabled after 1.4 Upgrade, ready for review.
I also suggest to the maintainers to update the documentation page, with adding the information regarding the updating from 1.3 to 1.4 so there is no confusion.
And also, test are expected to fail due to core issue related to migrations #3192893: [META] Serialization issues in Migration tests.
Comment #20
deaom commentedAdded additional Q and A for #3195164: Option to disable destination.
Comment #22
rushikesh raval commentedI have reviewed MR!26. It is now as per drupal recommendation.
So moving it to RTBC
Comment #23
admirlju commentedBecause js-cookie was deprecated in Drupal 10 and will be removed in Drupal 11 this module now depends on JS Cookie module. Add the requirements to the README.md
Comment #24
admirlju commentedRebased so tests can pass on the MR26
Comment #25
deaom commentedRemoved the Q&A that was added (by me) for the option to disable destination, as some other configuration changes will be added in the future and I think the first Q&A covers it with the configuration export (as all the new configuration features will be added to the new release), but did remove the to 1.4 in the Q as not sure what the new version will be, but basically applies for upgrading from 1.3 or 1.4 version. Maybe wording needs to be different for the Q (How to upgrade from version 1.3 to 1.4 or later?)? Not sure, so leaving it to needs review.
Comment #26
ressaThanks @DeaOm. Perhaps @gowthamrajkrishnasamy or someone with the right permissions can hide or delete the irrelevant branch 3315952-replace-readme.txt_to_readme.md?
Comment #28
deaom commentedRebased MR, as it's just a Readme file, it can be applied to 8x and 2x branch, but can't change the MR target branch.
Comment #30
the_g_bomb commentedRebased MR
Comment #31
the_g_bomb commentedComment #32
inregards2plutoRe the new release roadmap, I'm wondering if it makes since to address the other outstanding tickets first, THEN update this to reflect any new features added in?
Comment #33
the_g_bomb commentedGood idea
Comment #34
the_g_bomb commentedI've updated the README with details of some of the recent changes.
Comment #35
the_g_bomb commentedComment #36
inregards2plutoReviewed changes. README.md is updated to reflect recently added features and bug fixes. Markdown and sections align with Drupal documentation at https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or....
Updating to RTBC.
Comment #37
the_g_bomb commentedMerged, thanks for the help
Comment #39
ressaThanks everyone!
Perhaps the doc link under "Resources" on the project page can be updated?
It's always best to not define a branch version in such links, to not have to eternally update it. Hopefully, @the_g_bomb can get the "Maintainer"-role before too long, to allow updating the default GitLab branch to 2.x :)