Coding standards issue fixes.

Issue fork key_auth-3315882

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rajeshreeputra created an issue. See original summary.

Rajeshreeputra opened merge request !8

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Assigned: rajeshreeputra » Unassigned
Status: Active » Needs review
sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

I will review the PR.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
solideogloria’s picture

solideogloria commented
Status: Needs review » Needs work

ankithashetty made their first commit to this issue’s fork.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review

MR is rebased and updated with #6 changes.

Noticed the below error:

/key_auth/src/KeyAuth.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
 5 | ERROR   | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements

Looks like it was added in #3272203: Key Auth authenticator should query for users without access check. Was it deliberately added or can we clean it?

Thanks!

solideogloria’s picture

solideogloria commented

I think the use Drupal; line should be removed.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented

Updated MR with #9 suggestion.
Thanks!

solideogloria’s picture

solideogloria commented
Status: Needs review » Closed (duplicate)
Related issues: +#3528017: [PHP 8.4] Fix code style issues reported by phpcs

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

solideogloria’s picture

solideogloria commented
Related issues: +#3570690: Fix the D11 compatibility of 2.x-dev