Problem/Motivation

Looks like the PHP syntax error fix from #3315326: 2.0.0-beta1 release added a dependency to file module, php syntax errors was also reverted.

Steps to reproduce

Attempt to install the module and it will fail to a syntax error:

ParseError: syntax error, unexpected token "&" in Drupal\Core\Extension\Extension->load() (line 91 of /github/home/drupal/modules/contrib/openid_connect/openid_connect.module) #0 /github/home/drupal/core/lib/Drupal/Core/Extension/ModuleHandler.php(128): Drupal\Core\Extension\Extension->load()
#1 /github/home/drupal/core/lib/Drupal/Core/Extension/ModuleInstaller.php(247): Drupal\Core\Extension\ModuleHandler->load('openid_connect')
#2 /github/home/drupal/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install(Array, true)
#3 /github/home/drupal/vendor/drush/drush/src/Drupal/Commands/pm/PmCommands.php(103): Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array, true)
#4 [internal function]: Drush\Drupal\Commands\pm\PmCommands->enable(Array, Array)
#5 /github/home/drupal/vendor/consolidation/annotated-command/src/CommandProcessor.php(257): call_user_func_array(Array, Array)
#6 /github/home/drupal/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object(Consolidation\AnnotatedCommand\CommandData))
#7 /github/home/drupal/vendor/consolidation/annotated-command/src/CommandProcessor.php(176): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#8 /github/home/drupal/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(350): Consolidation\AnnotatedCommand\CommandProcessor->process(Object(Symfony\Component\Console\Output\ConsoleOutput), Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#9 /github/home/drupal/vendor/symfony/console/Command/Command.php(255): Consolidation\AnnotatedCommand\AnnotatedCommand->execute(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /github/home/drupal/vendor/symfony/console/Application.php(1027): Symfony\Component\Console\Command\Command->run(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /github/home/drupal/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Consolidation\AnnotatedCommand\AnnotatedCommand), Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#12 /github/home/drupal/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#13 /github/home/drupal/vendor/drush/drush/src/Runtime/Runtime.php(118): Symfony\Component\Console\Application->run(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 /github/home/drupal/vendor/drush/drush/src/Runtime/Runtime.php(48): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#15 /github/home/drupal/vendor/drush/drush/drush.php(72): Drush\Runtime\Runtime->run(Array)
#16 /github/home/drupal/vendor/drush/drush/drush(4): require('/github/home/dr...')

See https://github.com/City-of-Helsinki/drupal-module-helfi-tunnistamo/actio...

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tuutti created an issue. See original summary.

tuutti’s picture

Status: Active » Needs review

webflo made their first commit to this issue’s fork.

webflo’s picture

Priority: Major » Critical

$account_form should be set by-reference. I created a new MR with the change: https://git.drupalcode.org/project/openid_connect/-/merge_requests/58

webflo’s picture

This also applies for 3.x.

jcnventura’s picture

jcnventura’s picture

Version: 2.0.0-beta2 » 3.x-dev

jcnventura’s picture

Indeed. Sorry, I just really have tested this before tagging them.

jcnventura’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.