Problem/Motivation

Symfony Mailer provides a back-compatibility module that overrides email building in other modules using an EmailBuilder plugin. These cause hook_mail() to be skipped, and instead the EmailBuilder generates the email using Email Policy configuration from this module. This module imports legacy configuration to generate equivalent Email Policy

Some sites may prefer to disable some or all of the override plugins to keep sending in compatibility mode.

Proposed resolution

We can replace the existing "Import" page with an "Override" page that handles both enabling and config importing as clearly the two are closely related.

GUI

  • Rename "Import" page to "Override".
  • 3 states: disabled, enabled, imported.
  • 3 operations: "Enable & import", "Enable" (no import, just default policy) "Disable" (also deletes policy).
  • Remove "Import All", instead have a table row for "All".
  • Similar changes for drush.

Code

  • Create a function to access this configuration OverrideManager::isEnabled()
  • Conditionally disable the plugins in symfony_mailer_mailer_builder_info_alter()
  • Conditionally disable the corresponding hooks: symfony_mailer_bc_form_alter(), MailerBcConfigOverride and any others.
  • Move config currently in symfony_mailer_bc/config/optional to new directory at same level mailer_override.
  • Code to import config from */config/mailer_override
  • New value in EmailBuilder annotation: "override_warning".

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#24 symfony_mailer.proxy-manage.3315358-24.patch8.42 KBadamps
#21 symfony_mailer.proxy-manage.3315358-interdiff-20-21.txt3.01 KBadamps
#21 symfony_mailer.proxy-manage.3315358-21.patch85.99 KBadamps
#20 symfony_mailer.proxy-manage.3315358-interdiff-19-20.txt15.99 KBadamps
#20 symfony_mailer.proxy-manage.3315358-20.patch85.83 KBadamps
#19 symfony_mailer.proxy-manage.3315358-19.patch78.57 KBadamps
#18 symfony_mailer.proxy-manage.3315358-interdiff-17-18.txt4.32 KBadamps
#18 symfony_mailer.proxy-manage.3315358-18.patch73.65 KBadamps
#17 symfony_mailer.proxy-manage.3315358-interdiff-15-17.txt5.97 KBadamps
#17 symfony_mailer.proxy-manage.3315358-17.patch72.61 KBadamps
#15 symfony_mailer.proxy-manage.3315358-15.patch68.19 KBadamps
#15 symfony_mailer.proxy-manage.3315358-interdiff-14-15.txt8.31 KBadamps
#14 symfony_mailer.proxy-manage.3315358-interdiff-13-14.txt10.02 KBadamps
#14 symfony_mailer.proxy-manage.3315358-14.patch68 KBadamps
#13 symfony_mailer.proxy-manage.3315358-interdiff-12-13.txt22.22 KBadamps
#13 symfony_mailer.proxy-manage.3315358-13.patch66.88 KBadamps
#12 symfony_mailer.proxy-manage.3315358-interdiff-11-12.txt17.04 KBadamps
#12 symfony_mailer.proxy-manage.3315358-12.patch63.04 KBadamps
#11 symfony_mailer.proxy-manage.3315358-interdiff-9-11.txt603 bytesadamps
#11 symfony_mailer.proxy-manage.3315358-11.patch61.1 KBadamps
#9 symfony_mailer.proxy-manage.3315358-interdiff-6-9.txt10.31 KBadamps
#9 symfony_mailer.proxy-manage.3315358-9.patch61.07 KBadamps
#7 symfony_mailer.proxy-manage.3315358-interdiff-5-6.txt21.03 KBadamps
#7 symfony_mailer.proxy-manage.3315358-6.patch54.56 KBadamps
#6 symfony_mailer.proxy-manage.3315358-5.patch48.29 KBadamps
#5 symfony_mailer.proxy-manage.3315358-interdiff-4-5.txt14.42 KBadamps
#4 symfony_mailer.proxy-manage.3315358-4.patch51.22 KBadamps
#3 symfony_mailer.proxy-manage.3315358-3.patch40.69 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

Title: Allow disabling of proxy plugins » Allow full management of proxy plugins
Issue summary: View changes
adamps’s picture

Status: Active » Needs work
StatusFileSize
new40.69 KB

Work in progress

adamps’s picture

StatusFileSize
new51.22 KB
adamps’s picture

Status: Needs work » Needs review
StatusFileSize
new14.42 KB
adamps’s picture

StatusFileSize
new48.29 KB
adamps’s picture

adamps’s picture

Title: Allow full management of proxy plugins » Allow full management of override plugins
Issue summary: View changes
adamps’s picture

Status: Needs review » Needs work

The last submitted patch, 9: symfony_mailer.proxy-manage.3315358-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

Status: Needs work » Needs review
StatusFileSize
new61.1 KB
new603 bytes
adamps’s picture

adamps’s picture

adamps’s picture

adamps’s picture

adamps’s picture

Issue summary: View changes
adamps’s picture

adamps’s picture

adamps’s picture

adamps’s picture

adamps’s picture

  • AdamPS committed 3b058edd on 1.x
    Issue #3315358 by AdamPS: Allow full management of override plugins
    
adamps’s picture

Status: Needs review » Fixed

Phew, that was a tricky one😃

adamps’s picture

Status: Fixed » Needs review
StatusFileSize
new8.42 KB

Improvements and corrections

  • AdamPS committed fba823e2 on 1.x
    Issue #3315358 by AdamPS: Allow full management of override plugins (...
adamps’s picture

Status: Needs review » Fixed

NB Both patches 21 and 24 were committed

adamps’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.