Related to #3312966: Enforce the use of CSS Logical Properties in core

Problems

  1. Core's .stylelintrc.json does not include CSS logical properties within the order/properties-order section. This means that our linting does not enforce properties order for those properties.
  2. There's a lot of unneeded properties that have browser prefixes in .stylelintrc.json (examples: -ms-overflow-x, -o-transition-duration).

Solutions

  1. Add CSS logical properties to .stylelintrc.json.
  2. Remove unneeded CSS properties from .stylelintrc.json.
CommentFileSizeAuthor
#6 logical-css-stylelint-3314921-6.patch5.62 KBakashdab
#2 stylelintrc_json_3314921.patch8.76 KBakshay_sargar

Issue fork drupal-3314921

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

akshay_sargar’s picture

akshay_sargar commented
StatusFileSize
new stylelintrc_json_3314921.patch8.76 KB

Updated Unneeded CSS logical properties from .stylelintrc.json.

akshay_sargar’s picture

akshay_sargar commented
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs work

Thanks for the patch.

This still needs work. There's changes to unit-allowed-list and ignoreFiles

In addition, I don't see the new logical properties added anywhere.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

akashdab’s picture

akashdab commented
StatusFileSize
new logical-css-stylelint-3314921-6.patch5.62 KB

- Added css logical properties
- removed unneeded properties that have browser prefixes
- did not alter unit-allowed-list and ignoreFiles

ahsannazir made their first commit to this issue’s fork.

ahsannazir opened merge request !8225

Gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

MR has failures

Issue summary should be updated to standard template and mention about adding a new package, how it was determined which properties to drop/add

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.