The constuctor of the SearchApiDisplay class (facet source) expects classes in it's constructor instead of interfaces.

We should change that and expect interfaces, because this will break, if a non supported class is injected to the plugin (e.g. someone decorates the ModuleHandler).

Issue fork facets-3314702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Marios Anagnostopoulos created an issue. See original summary.

marios anagnostopoulos’s picture

marios anagnostopoulos commented
Status: Active » Closed (duplicate)

I now realized that this is a duplicate of https://www.drupal.org/project/facets/issues/3308343, since the ModuleHandlerInterface is the important one I guess.

If no other constructor properties need to be addressed (e.g. the RequestInterface, QueryHelperInterface) feel free to close a dup.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#3308343: Use the ModuleHandlerInterface instead of the ModuleHandler concrete implementation

👍

marios anagnostopoulos’s picture

marios anagnostopoulos commented
Status: Closed (duplicate) » Needs work

Reopened as per a comment in slack.

Marios Anagnostopoulos opened merge request !110

marios anagnostopoulos’s picture

marios anagnostopoulos commented
Status: Needs work » Needs review

Tests were failing because I executed them against 7.3, whilst there is 7.4 typehinting in search_api
7.4+ seems ok so I will be changing to needs review.

mkalkbrenner made their first commit to this issue’s fork.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Version: 2.0.5 » 2.0.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.