Within the new PostCSS for the off-canvas dialog, we neglected to include an ampersand (&) within a nested PostCSS block (see https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/misc/dialog...).

There are no differences in the visual styles because the values fall back from the correct CSS custom property to the the same value via inheritance. That being said, when someone extends the styles, the link colors may not match as expected.

Issue fork drupal-3314574

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue tags: +Novice

amit.mall made their first commit to this issue’s fork.

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !2944

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review

Please review.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

Thanks for the patch @rpayanm, but you also need to add the compiled CSS to the MR. You can generate this by runningyarn build:css from the /core directory

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

@mherchel Thank you so much!

I used that command and pushed my changes, please review it.

rpayanm opened merge request !3157

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented

I created a new branch because I did the last one, and it looked weird lol
It also needed a rebase.

diegors made their first commit to this issue’s fork.

diegors’s picture

diegors
He/Him
Primary language Portuguese, Brazil
Location Campinas - Brazil
commented

I did the rebase, still need review.

xjm closed merge request !2944

xjm’s picture

xjm
she/her
Primary language English
commented

As a change to module CSS, this should be minor-only.

There seem to be two merge requests open against this issue, both of them against 10.1.x. However, one of them looked like a bad merge with hundreds of unrelated changes, so I closed it.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs manual testing

It would be good to have before-and-after manual testing of the links in the affected off-canvas markup. Since this is changing CSS output by core/misc, I think that means we also need to check all of Claro, Olivero, Classy, Stable 9, and Starterkit to see if they need the same fix.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Think it would help to know where this appears?

Tried testing in layout builder but the markup doesn't go

#drupal-off-canvas-wrapper summary a

but
#drupal-off-canvas-wrapper summary span

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Closed (duplicate)

Closing as duplicate of #3361839: Accidental use of CSS nesting in misc/dialog/off-canvas/css/details.css