Problem/Motivation

Follow-up of #3291797: Refactor Drupal 10 settings tray / off-canvas to use modern CSS, a & is missing that causes it to generate CSS with nested definitions.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3361839

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Berdir created an issue. See original summary.

BramDriesen made their first commit to this issue’s fork.

BramDriesen opened merge request !4028

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Seems straight-forward enough.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

This is a duplicate of #3314574: Invalid PostCSS causes invalid CSS within new off-canvas CSS, but I'm all for committing this as this is an easy fix.

longwave credited rpayanm.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Related issues: +#3314574: Invalid PostCSS causes invalid CSS within new off-canvas CSS

Closed the linked issue as duplicate, credited the user that came up with the same fix over there.

  • longwave committed abd5bde6 on 10.0.x 
    Issue #3361839 by BramDriesen, mherchel, rpayanm: Accidental use of CSS...

  • longwave committed 5e7cf3cf on 10.1.x 
    Issue #3361839 by BramDriesen, mherchel, rpayanm: Accidental use of CSS...

  • longwave committed 0816a048 on 11.x 
    Issue #3361839 by BramDriesen, mherchel, rpayanm: Accidental use of CSS...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 11.x and 10.1.x.

Backported to 10.0.x as well; the .pcss.css applied directly but the .css did not - but that could be easily fixed with yarn build:css on commit.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.