Problem/Motivation

Since MediaElement 5.0.0 was added the parameter iconSprite that indicates the location of the svg icon controls and is needed to be set on the library instance in order to show correctly the player.

Player withour controls

More info: https://github.com/mediaelement/mediaelement/blob/6b21f69a048f42ff2447b4...

Proposed resolution

Creates a new settings under player_settings to stores the path of the svg, by default sets '/libraries/mediaelement/build/mejs-controls.svg'.

Remaining tasks

This parameter of MediaElement could be problematic using CDN, in this moment i don't know how to handle, temporary local library is required to set the local path of the svg.

Comments

MaxMendez created an issue. See original summary.

maxmendez’s picture

Here my first approach

maxmendez’s picture

Issue summary: View changes
maxmendez’s picture

StatusFileSize
new2.83 KB

Sorry, i've attached an old patch with some errors.

junaidpv’s picture

Category: Feature request » Bug report
Status: Active » Needs review
StatusFileSize
new1.03 KB

I don't think that needs to be a configurable one. It is a known path within the library and usually no need to change.
Here is a version that works with both local and CDN. Without making that configurable thus a simpler patch.

jldust’s picture

Status: Needs review » Reviewed & tested by the community

The simpler patch worked perfectly!

  • jnettik committed 9f7a52fd on 2.x
    Issue #3314514 by maxmendez, junaidpv, jldust: Implements iconSprite...
jnettik’s picture

Status: Reviewed & tested by the community » Fixed

This has been committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.