Due to drupal infrastructure changes the eslinting coding standard process is reporting unrequired and incorrect coding starndards faults. See #3314390: prettier eslint plugin reports bogus errors for contrib projects

Scheduler tests show 1,600+ faults in .yml files which should be ignored in the the Drupal eslint standard. This can obscure one or two 'real' coding standards faults.

Issue fork scheduler-3314451

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented

Until the issue is fixed we may be able to ignore the .yml files by adding Scheduler's own .prettierignore file. First make sure we are linting at least one changed .yml file.

jonathan1055 opened merge request !68

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

The 2.x branch test reports 10 faults in config/install/scheduler.settings.yml. This MR should report 9 now.

jonathan1055’s picture

jonathan1055 commented

No faults reported - log says

11:31:33 ----------------   Starting eslint   ----------------
11:31:33 Directory created at /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-127017/ancillary/eslint
11:31:33 eslinting the project.
11:31:33 No modified files are eligible to be sniffed

I don't know why the modified .yml file is not being checked.

  • jonathan1055 committed 1d0ccdd on 2.x 
    Issue #3314451 by jonathan1055: Eslint coding standards faults - add ....
jonathan1055’s picture

jonathan1055 commented

Branch tests at core 9.4 are clean but at 9.5 we get warnings about .yml indentation. Is there a newer version of eslint being run?

jonathan1055 opened merge request !70

  • jonathan1055 committed 7900449 on 2.x 
    Issue #3314451 by jonathan1055: Fix indentation in .yml files (eslint 8....
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

At Core 9.5 and 10.0 we get eslint version 8.23 compared to eslint 8.14 on core 9.4
I presume 8.23 checks more things (such as indentation of comments) compared to 8.14.
Fixed on 2.x

  • jonathan1055 committed 0d79c86 on 8.x-1.x 
    Issue #3314451 by jonathan1055: Eslint coding standards faults - add ....
jonathan1055’s picture

jonathan1055 commented

Back-ported to 8.x-1.x. This should reduce the eslint coding faults from 586 down to just a few that should be fixed.

jonathan1055’s picture

jonathan1055 commented

That's better. Now only 2 yml faults on 8.x-1.x.

  • jonathan1055 committed cc63692 on 8.x-1.x 
    Issue #3314451 by jonathan1055: Fix indentation in .yml files (eslint 8....
jonathan1055’s picture

jonathan1055 commented

and those are fixed now, too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.