At the moment, the different plugins are somewhat confusing, since we have 3 working types of plugins (not sure if the Send plugins can even work..):
The problem with the current setup is that the TfaSetup plugin doesn't really exist, as it is simply an extension of one of the other plugins. In addition, the ones provided by the module all extend the other plugin class, so in reality, all the plugins are already a TfaSetup plugin anyway.
We can easily unify all the modules, and distinguish their personalities on whether they implement a given interface or not. This way, it would be much simpler to create new plugin types by simply declaring a new interface.
Finally, the current plugin managers are very opinionated in which services can be injected into each plugin, and the core TFA module should not be making those decisions. Better allow plugin constructors by injecting the container.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | tfa-unify-plugins-3314265-6.patch | 226.91 KB | jcnventura |
| #6 | interdiff_4_6.txt | 6.11 KB | jcnventura |
Comments
Comment #2
jcnventuraComment #3
jcnventuraTestbots are go!
Comment #4
jcnventuraRe-rolling after all the latest changes.
Comment #6
jcnventuraAnd now fixing the re-roll bugs.
Comment #8
jcnventura