When using the password_policy_history plugin and set history_repeats to 0, the plugin is showing a confusing error message during validation.
When `history_repeats` is set to 0, the error message should be something like:
Previous passwords cannot be reused. Choose a different password.
But the error message actually seen is:
The last 0 passwords cannot be reused. Choose a different password.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot from 2022-11-01 01-59-01.png | 36.89 KB | gabrieldv |
| #2 | password_policy-password_policy_history_error_message-3314234-2.patch | 1.5 KB | mediabounds |
Comments
Comment #2
mediabounds commentedThe plugin actually does have a special error message for when `history_repeats` is set to 0, but it immediately overwrites the special message with the default one. This patch fixes that.
Comment #3
jfurnas commentedApplied this patch today, and it works as intended.
Comment #4
gabrieldv commentedI'll try to review it, thanks for the patch @mediabounds =)
Comment #5
gabrieldv commentedI tested the #2 patch and it resolves the problem in this issue, i also runned the automated tests and it runs very good, so i'm moving this to RTBC.
Comment #6
gabrieldv commentedComment #8
paulocsThanks.
Comment #9
paulocs