Problem/Motivation

7.x-3.x is being deprecated, we need to add a EOL message to the status report. Once the EOL has passed, we need to disable all API calls to NSPI.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 3314139-9.patch2.51 KBmglaman
#7 3314139-7.patch2.97 KBmglaman
#5 interdiff_2-5.txt2.67 KBnkoporec
#5 3314139-5.patch3.66 KBnkoporec
#2 0001-Add-EOL-message-and-kill-switch.patch3.08 KBnkoporec

Issue fork acquia_connector-3314139

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Active » Needs review
StatusFileSize
new 0001-Add-EOL-message-and-kill-switch.patch3.08 KB
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Related issues: +#3314126: EOL message for 3.x

Waiting to get finalized messaging on #3314126: EOL message for 3.x.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

We need the time checks to respect timezones: 

new \DateTime('Tue Nov 15 2022', new \DateTimeZone('GET TIMEZONE'));
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs work » Needs review
StatusFileSize
new 3314139-5.patch3.66 KB
new interdiff_2-5.txt2.67 KB

Updated the patch and used \DateTime instead of timestamps.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented 
+++ b/acquia_agent/acquia_agent.install
@@ -86,8 +86,10 @@
+      $eol_warning_date = new \DateTime('Tue Nov 15 2022', new \DateTimeZone(date_default_timezone_get()));
+      $current_date = new \DateTime('now', new \DateTimeZone(date_default_timezone_get()));

@@ -95,8 +97,9 @@
+        $eol_date = new \DateTime('Wed Mar 01 2023', new \DateTimeZone(date_default_timezone_get()));

+++ b/acquia_agent/acquia_agent.module
@@ -240,8 +240,10 @@
+  $eol_date = new \DateTime('Wed Mar 01 2023', new \DateTimeZone(date_default_timezone_get()));
+  $current_date = new \DateTime('now', new \DateTimeZone(date_default_timezone_get()));

Can't we just omit the second parameter if we're using the default timezone? When passing null that's what it will use: https://www.php.net/manual/en/datetime.construct.php

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3314139-7.patch2.97 KB

reroll dropping timezone stuff, we could use the user timezone function, but best to just pass null for system default.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Needs work

Keep the subscription data, just make surre the response is intercepted with a blank return or something that makes connector think the subscription is not active. Once they upgrade to 4.0.0 everything should come back without needing to re-login.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3314139-9.patch2.51 KB

Let's see how this goes. Ensures subscription is considered not-active, and doesn't break response handling to acquia_agent_call

Status: Needs review » Needs work

The last submitted patch, 9: 3314139-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • japerry committed 50e4e20 on 7.x-3.x 
    Issue #3314139 by nkoporec, mglaman: EOL message for 7.x-3.x
japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.