Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues

Video meeting 2022-10-13 2100Z

The hope is that most or all of the maintainers will attend. We will try to focus on longer-term goals than in the weekly meeting.

0️⃣ Who is here today?

damienmckenna :wave:
Marios Anagnostopoulos :tada:
danflanagan8 :pizza:
benjifisher Hi, @Marios Anagnostopoulos! Is this your first time at this meeting?
Marios Anagnostopoulos Yeap, It is, I have some experience in doing migrations, but haven't really contributed yet to migration related modules.
benjifisher Feel free to lurk for this meeting, or comment in 4️⃣ if you want ideas on what to do. (Hint: there is plenty to do!)
mikelutz (he/him) hey all
dinarcon Hola :wave:
heddn hola
James Shields Hi, I'm a bit late for today, but will try to join in in future. I'm fairly new to migration, but can see some areas where documentation could use improving.
benjifisher What is he talking about?
quietone HI, catching up

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

danflanagan8 Here’s the issue I want @mikelutz (he/him) to close as will not fix this week: #2905929: Better document how skip_on_empty works with multiple value sources
damienmckenna Might anyone be able to give a quick summary of the migration improvements in 9.5/10.0?
dinarcon The complete node migration change records says that classic migrations are deprecated. https://www.drupal.org/node/3105503 As pointed out in the comments, I think they are still useful when you only need to migrate the latest revision and there are no translations. It would be nice to know if the migrate maintainers would change their mind in deprecating the classic approach. (edited)
mikelutz (he/him) That CR specifically says that the classic migrations are NOT deprecated.

2️⃣ Action items. To be added later.

3️⃣ Statistics

benjifisher Fixed since last week's meeting: 6
benjifisher RTBC: 0
benjifisher NR: 11 (not counting issues for meetings), including 2 Major and 2 that have not been updated in more than two months.
benjifisher Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...
benjifisher Big :thankful: to @alexpott for clearing out the RTBC queue! Not all are Fixed: at least one of the Major issues in NR status was knocked back from RTBC.

4️⃣ Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

Marios Anagnostopoulos It would be nice to have some (probably low priority /  nice to haves) issues to work on for an introductory onboarding to the codebase. If such an issue exists atm.
benjifisher You can troll through https://www.drupal.org/project/issues/drupal?status=Open&component=migra.... Find an issue that has not been updated in, say, 2 weeks, so you are not duplicating someone else's efforts. Look for one that does not have a ton of comments (history).

Ask for advice here. If you want to do some testing and need steps to reproduce, someone can help.
Marios Anagnostopoulos I guess you meant stroll :stuck_out_tongue: but yeah I'll have a look, thanks!
benjifisher Are you more interested in testing, coding, or review? Do you want to help with an issue that already has work done on it, or would you like to start fresh?
benjifisher In these meetings, we usually focus on core issues, but there are 201 open issues for Migrate Plus: https://www.drupal.org/project/issues/migrate_plus?categories=All
Marios Anagnostopoulos Coding initially, to get a good feel of the codebase... core or migrate plus is fine either way, if you have an issue to suggest.
benjifisher This one is on the border between coding and documentation, but it would be a good way to get familiar with the codebase: #3261042: Make docblocks of migrate plugins consistent
benjifisher I have not looked at it, but this core issue may be manageable: #3005718: D7 comment migration does not properly migrate fields by comment bundle.
Marios Anagnostopoulos I will have a look at them both, thanks :slightly_smiling_face:

5️⃣ Previous minutes.

benjifisher
benjifisher The 2022-09-29 meeting is now NR.
benjifisher I am adding credit for 2022-09-22. @greg-boggs, is this you? https://www.drupal.org/u/gregboggs
benjifisher Make that 2022-09-15. I marked the one for 09-22 as Fixed.
greg-boggs https://www.drupal.org/u/greg-boggs

6️⃣ Announcements

benjifisher Next week will be the quarterly video meeting. We will post a Zoom link in this channel shortly before the meeting. We may also add it to the calendar item and/or the meeting issue ahead of time. #3313883: [meeting] Migrate Meeting 2022-10-13 2100Z

7️⃣ Update Drupal 7 migration database fixture

benjifisher #3219539: Update Drupal 7 migration database fixture
benjifisher This is one of the Major issues in the NR queue.
mikelutz (he/him) Yeah, I’m all for doing it, it’s pretty much impossible to review it by looking at the patch though. I need to fire up my D7 site for this and test it, and I haven’t gotten to it yet.  I was also trying to think of whether there are any other changes we want to make to the fixture while we are in there. It would be nice if it were easier to change.
mikelutz (he/him) One thing I keep coming back to is that we throw everything in there, including all modules that are now in core, for the testing purposes. Kinda the most complicated situation we can build that we support, but I run into situations where we aren’t testing simpler setups with module X disabled, and somethings don’t quite work the same.  We do some of that with pre-test modification queries, but I wish there was a better way, not that I know what it could be.
mikelutz (he/him) There’s a ticket to add support for the uuid d7 module in the core migrations, which we should definitely do, but that one is tricky for a few unique reasons, and whatever we do definitely needs to be tested both with and without that module and associated database columns.
mikelutz (he/him) I have this fantasy of being able to supply some kind of yaml based d7 configuration manifest and being able to generate a testing database from it, but that’s obviously not practical, lol.
mikelutz (he/him) Anyway, I’m sure the patch for that is fine, if tests are passing, but I did want to try loading it in d7 before I RTBC it.
benjifisher Yes, the T is for "tested".
danflanagan8 That’s why I love test-only changes. No need for the T. :slightly_smiling_face:
quietone I see that this is now RTBC. Yeah!
quietone I'll be making a followup to fix the problem mention in 18.2, that two nodes fail to load.

8️⃣ Better document how skip_on_empty works with multiple value sources

benjifisher #2905929: Better document how skip_on_empty works with multiple value sources
benjifisher Suggestion: close as Won't Fix. It is best if one of the maintainers does that.
danflanagan8 Or maybe marking as “duplicate” would be a softer choice.
mikelutz (he/him) No, won't fix is correct here.
danflanagan8 The knives are out!
danflanagan8 Thanks, @mikelutz (he/him).

9️⃣ $migration_dependencies has inconsistent structure

benjifisher #3262395: $migration_dependencies has inconsistent structure
benjifisher This is the other Major issue in the NR queue. It is a blocker for  #2796755: [PP-1] Deprecate Migration::set() .
quietone This is on my list. I hope to get to this before monday.
benjifisher Thanks. alexpott already left a comment on the MR, and I will reply.

1️⃣0️⃣ Migration improvements in Drupal 9.5/10.0

benjifisher Maybe more of a change or a bug fix, not an improvement: #2953111: Only migrate role permissions that exist on the destination is the migration piece of the related change in Drupal 9.3.
benjifisher Why has Slack stopped showing previews of my links?

Only migrate role permissions that exist on the destination
dinarcon Benji noted this one the other day as well #3096101: Allow migrate_drupal_ui source database to be set in settings.php
benjifisher Fixed in the last week:

Feel free to pick out any of the others from that list that seem noteworthy. (edited)
benjifisher x-post
danflanagan8 I know it’s contrib, but I’ve been working hard the last few weeks and making some (I think!) really useful improvements in Migrate Sandbox and Migrate Conditions.
benjifisher And you have been working on the documentation. :thankful:

1️⃣1️⃣ Complete node migrations and Classic node migrations

benjifisher Copied from 0️⃣:

The complete node migration change records says that classic migrations are deprecated. https://www.drupal.org/node/3105503 As pointed out in the comments, I think they are still useful when you only need to migrate the latest revision and there are no translations. It would be nice to know if the migrate maintainers would change their mind in deprecating the classic approach. (edited)
benjifisher
When using drush to run migration both the classic and complete migrations are available.

Currently, you can choose classic or complete. The only question is whether you will continue to have that choice.
benjifisher The CR says,

The complete node migration will eventually replace ... the classic node migrations.

but it also says,

The classic node migrations are not yet deprecated.

Has that changed since the CR was written? Is there anything in code to deprecate the classic migrations?
heddn both make sense to have available
mikelutz (he/him) No, they have definitely not been deprecated. Not the migration plugins, nor the sources or destinations. There are no immediate plans to do so.
heddn @dinarcon want to update the CR?
mikelutz (he/him) I don’t know that it’s necessary to update anything there. It’s all accurate.
mikelutz (he/him) They do functionally replace the existing ones, the existing ones are not deprecated. Eventually they will all be deprecated and moved to contrib.
heddn I've changed to:

The classic node migrations are not deprecated. Both exist in core and other migrations that depend on the node migrations are modified at run time to work with both the classic node migration and the complete node migration.
heddn this removes: The classic node migrations are not _yet_ deprecated
heddn that 3 letter word was confusing (i think)
dinarcon Cool. I guess I misinterpreted that CR copy. Thanks for chiming in and clarifying.

1️⃣2️⃣ Wrap up

benjifisher Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.

Comments

benjifisher created an issue. See original summary.

benjifisher credited DamienMcKenna.

benjifisher credited danflanagan8.

benjifisher credited dinarcon.

benjifisher credited heddn.

benjifisher credited Marios Anagnostopoulos.

benjifisher credited quietone.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Issue summary: View changes
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Active » Needs review
quietone’s picture

quietone commented
Issue summary: View changes

Add formatting, mostly quotes and lists.

quietone’s picture

quietone commented
Status: Needs review » Fixed

I reviewed my formatting changes and there was no change to content so I am going to set this to fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.