getCleanSeparators() in AliasCleaner class uses strlen() to check for the length of the string. When config has a value of NULL, the strlen(NULL) check issues a warning in PHP8.1.
Run tests in PHP 8.1
Replace 1 line `if (strlen($separator)) {` with `if (!empty($separator)) {`
Using strlen() to check for emptiness is not a good idea anyway - it is not the purpose of this function.
None
None
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | parsing_null_to_parameter-3313566-12.patch | 428 bytes | adeshsharma |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
berdirthose configs are expected to be empty strings not null, if some are null, especially ignore words then you likely reverted some previous update functions, I would expect that resaving the config page should fix that, if the config page is even working. if not you'll need to change it manually.
Comment #4
srijeeta commentedComment #5
srijeeta commentedHi,
Added a patch for strlen issue, also ran rector to check the compatibility with php 8.1
Comment #6
srijeeta commentedComment #7
damienmckennaThe patch doesn't include the MR's changes and seems like it's solving a different issue?
As a reminder, please set the "assigned" field back to "unassigned" when you're finished with an issue. Thank you.
Comment #8
bharath-kondeti commentedComment #9
bharath-kondeti commentedComment #10
Lingamurthy commentedUsing php 8 coding syntax
Comment #11
anweshasinha commentedHi,
Added patch for the issue according to php 8.1.22 standard. Please review the patch
Comment #12
adeshsharma commentedModified operator content check
Comment #13
adeshsharma commentedComment #14
damienmckennaFor completeness sake, #12 would exclude certain characters from being allowed, e.g. a zero or a space. While, in practical terms I suspect these exceptions should be allowed (who would use "0" or a space as a separator in their URLs anyway?), I think it might be best to make sure the string is being vetted the same as the separator form field itself.
Comment #15
berdirYes, seems like the MR is the best solution for this.
Per #3, this should only happen if you have incomplete settings, I've fixed some issues that caused fatal errors and prevented users from even changing the settings, but that's not the case here. Resaving the settings form should IMHO get rid of this problem.
The MR can't be rebased through the UI it seems, please do that manually.
Comment #16
solideogloria commented!empty($string)isn't a correct way to check for a string's emptiness.empty('0') === TRUEStill, as Damien suggested, who would use that as a separator?
Comment #18
mably commentedMR has been rebased.
Comment #19
solideogloria commentedComment #20
mably commentedComment #22
mably commented