See here: ViewsTest::testViewSorts() is currently failing under Drupal 10 and I don’t really know why. Should, of course, be fixed ASAP.

CommentFileSizeAuthor
#5 3313195-5--fix_failing_test_d10.patch1.1 KBdrunken monkey

Issue fork search_api-3313195

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drunken monkey created an issue. See original summary.

nkoporec made their first commit to this issue’s fork.

nkoporec opened merge request !57

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Active » Needs review

I found out that the sort field is never rendered when running the testViewSorts() and therefore the sort_by is never applied to the form, that is why the tests are failing. I'm not sure why exactly but adding the 'field_identifier' key to the view config for the sort filter fixes the issue and the field is correctly displayed.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3313195-5--fix_failing_test_d10.patch1.1 KB

Thanks a lot for investigating!
Very strange problem, but if the solution is this simple, then great. At least it definitely shouldn’t do any harm to change an exported test config.

Uploading your changes as a patch, as testing of forks doesn’t work in this project (cf. #3190024: Problem with test dependencies when testing issue forks).

  • drunken monkey committed f4772ef on 8.x-1.x 
    Issue #3313195 by nkoporec, drunken monkey: Fixed failing ViewsTest::...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Test bot is happy as well, so let’s not waste any more time.
Committed. Thanks a lot again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.