Problem/Motivation

SearchApiFilterLocation::operatorOptions uses t() instead of $this->t() and has other PHPCS issues.

Proposed resolution

Replace t() with $this->t() and fix PHPCS issues.

Issue fork search_api_location-3313095

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

linichalexey created an issue. See original summary.

linichalexey opened merge request !6

linichalexey’s picture

linichalexey commented
Assigned: linichalexey » Unassigned
Status: Active » Needs review
juancec’s picture

juancec commented
Title: SearchApiFilterLocation uses t() instead of $this->t() » Coding standard issues
Assigned: Unassigned » juancec
Issue summary: View changes
Status: Needs review » Needs work

Hi @linichalexey. The "$this->t() should be used instead of t()" issues have been fixed, good job, but there are still PHPCS issues remaining. I'll fix them.

juancec’s picture

juancec commented
Assigned: juancec » Unassigned
Status: Needs work » Needs review

mahtab_alam made their first commit to this issue’s fork.

cinarb’s picture

cinarb commented
Assigned: Unassigned » cinarb

Hi ill review it

cinarb’s picture

cinarb commented
Assigned: cinarb » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi everyone, I look for phpcs errors and didn't find any. All the issues are fixed. I'll move this issue to RBTC. Good job!

borisson_ made their first commit to this issue’s fork.

  • borisson_ committed c208a6e on 8.x-1.x authored by linichalexey 
    Issue #3313095 by linichalexey, juancec, mahtab_alam, borisson_, cinarb...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Commited and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.