Problem/Motivation

I've updated one of our sites to the latest dev version of the module and noticed the following spacing issues:

* The default description text at the top of a taxonomy vocabulary is cut off:
taxonomy page alignment issue

* There is no padding between fields inside paragraphs, including nested paragraphs headers and their fields too:
paragraphs spacing issues

* The 'Show row weights' button overlaps the paragraphs:
Show row weights button overlap

As a temporary fix I've added the following to my gin-custom.css file but not sure if this is the right way to go about it: 

.paragraphs-subform > .form-wrapper {
  padding-top: 1rem;
}

Haven't attempted to fix the taxonomy page and overlapping row weights button

CommentFileSizeAuthor
#12 3312656-12-after.png12.87 KBshyam_bhatt
#12 3312656-12-before.png15.42 KBshyam_bhatt
#7 3312656-7.patch290 bytesJunaid_Nayeem
#4 padding-issues-with-paragraphs-and-taxonomy-3312656-4.patch656 bytesjuancec
Screenshot 2022-09-29 at 16.42.37.png35.47 KBsergiur
Screenshot 2022-09-29 at 16.41.43.png157.56 KBsergiur
Screenshot 2022-09-29 at 16.40.58.png75.51 KBsergiur

Issue fork gin-3312656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sergiur created an issue. See original summary.

juancec’s picture

juancec commented
Assigned: Unassigned » juancec

Hi, I'll work on it.

Christopher Riley’s picture

Christopher Riley commented

+1 on this its making some of my staff crazy.

juancec’s picture

juancec commented
Assigned: juancec » Unassigned
Status: Active » Needs work
StatusFileSize
new padding-issues-with-paragraphs-and-taxonomy-3312656-4.patch656 bytes

Hey, I'm providing a patch that solves the taxonomy vocabulary and the padding between fields inside paragraphs. I could not reproduce the 'Show row weights' overlaping bug. This means there is still one bug to fix.

Arturo-q’s picture

Arturo-q commented
Assigned: Unassigned » Arturo-q

Hi, I will be working on it and try to reproduce the last bug.

Arturo-q’s picture

Arturo-q commented
Assigned: Arturo-q » Unassigned

Hey, I review @juancec patch, and it fixes the taxonomy and the fields, but I was not able to reproduce the “show rows weights” error either.
Could you give us more information about the form or configurations?

Junaid_Nayeem’s picture

Junaid_Nayeem commented
Status: Needs work » Needs review
StatusFileSize
new 3312656-7.patch290 bytes

The above patch seems not working.Providing a new patch for the issue. This works fine for Drupal-8.9.

saschaeggi made their first commit to this issue’s fork.

saschaeggi opened merge request !184

saschaeggi’s picture

saschaeggi
he/him
commented

MR with fixes is opened: https://git.drupalcode.org/project/gin/-/merge_requests/184
Needs a review

saschaeggi’s picture

saschaeggi
he/him
commented

This needs a review

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3312656-12-before.png15.42 KB
new 3312656-12-after.png12.87 KB

@saschaeggi "MR !184" working fine. I have checked the MR !184the padding issue was resolved after applying the patch. Please check the below images.

Before patch:
2022-10-10/3312656-12-before.png

After patch:
2022-10-10/3312656-12-after.png

  • saschaeggi committed 6996360 on 8.x-3.x 
    Issue #3312656: padding issues with paragraphs and taxonomy
saschaeggi’s picture

saschaeggi
he/him
commented
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.