Needs work
Project:
Olivero
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Sep 2022 at 15:07 UTC
Updated:
2 Oct 2026 at 09:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mherchelComment #3
mherchelComment #4
mherchelRe-roll within minor changes attached.
Minor changes
Comment #6
mherchelRandom test failures are no longer failing. This is ready for review.
Comment #7
ckrinaLGTM!
Comment #8
lauriiiWhy are we changing the transition?
This slightly changes the margin inside the details. I think this looks better with the value before the change because the elements inside the wrapper are aligned with the summary.
Comment #9
gauravvvv commentedAddressed #8, attached patch for same.
Comment #10
mherchelIs there an interdiff to see what changed?
Comment #11
gauravvvv commentedI tried applying patch #4, but I was getting an error. That's why didn't provided interdiff.
I have replaced
transition: background-color 0.2s;withAlso, replaced
margin: calc(2 * var(--details-spacing-unit)) calc(1.5 * var(--details-spacing-unit));withmargin: var(--sp1-5) var(--sp2);in the patch.Comment #12
smustgrave commentedTested out by enabling Olivero when creating content
When to node/add/page
The details section doesn't seem broken. Here's a few screenshots but let me know if there's another section to check.
Comment #17
saurav-drupal-dev commentedCreate MR from patch
312636-9.patchComment #18
sagarmohite0031 commentedHello,
Tested and verified before applying MR.
Not able to reproduce issue looks good to me.
Attaching screenshots.
Comment #19
smustgrave commented@sagarmohite0031 there is not a need for additional screenshots when the ticket already has them. #12 I added screenshots and there's been no change since. Thanks
Restoring previous status.
Comment #20
nod_small nit left, it's a bit longer but it's more consistent.
Comment #22
quietone commentedThe Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.
Comment #23
quietone commented