Problem/Motivation

Display suite not compatible with hook_event_dispatcher

TypeError: Drupal\ds\Form\FieldFormBase::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/html/thro-web/web/modules/contrib/ds/src/Form/FieldFormBase.php on line 76 in Drupal\ds\Form\FieldFormBase->__construct() (line 61 of /var/www/html/thro-web/web/modules/contrib/ds/src/Form/FieldFormBase.php)

Steps to reproduce

try to edit DS "/admin/structure/ds/fields/manage_token/" field but make sure hook_event_dispatcher module is enabled

Proposed resolution

change the using module_handler class with its interface "ModuleHandlerInterface"

don't worry I will provide a patch for you :)

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
fix-ds-with-hook-entity-update.patch1.53 KBheshamkh

Comments

heshamkh created an issue. See original summary.

  • swentel committed 1dd1d32 on 8.x-3.x 
    Issue #3311925 by heshamkh: DS compatibility with hook_event_dispatcher
swentel’s picture

swentel commented
Status: Needs review » Fixed

Hmm yeah, forgot to backport that from the 5.0.x branch.

swentel’s picture

swentel commented
Status: Fixed » Closed (fixed)
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Hi @swentel, thanks so much for developing and taking care of the display suite module, it is greatly appreciated. I would like to pass a friendly reminder for a tag.

It's been a full year this has been fixed in the 8.x-3.x dev branch, yet there is still no tagged release with this fix.

Thank you,
@joseph.olstad