Problem/Motivation

VBO released a new version 23 Sept which cause a fatal error.

Declaration of Drupal\views_bulk_edit\Plugin\Action\ModifyEntityValues::buildPreConfigurationForm(array $form, array $values, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\views_bulk_operations\Action\ViewsBulkOperationsPreconfigurationInterface::buildPreConfigurationForm(array $element, array $values, Drupal\Core\Form\FormStateInterface $form_state): array

Steps to reproduce

Update VBO, view a previously working view page with the bulk edit now has errors.

Proposed resolution

Match the method to the intereface

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Issue fork views_bulk_edit-3311552

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pookmish created an issue. See original summary.

pookmish opened merge request !12

pookmish’s picture

pookmish commented
Status: Active » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PHP 8.0, +PHP 8.1

The MR fix is working :)
Thank you, Mike for filing the issue and the MR

Hoping that this fix is merged soon and the quick fix is released.

marassa’s picture

marassa commented

Works for me, thanks for the fix!

graber’s picture

graber commented

Yes, type hint was added. Best to solve this on VBE as we'd have to do it eventually anyway.
Thanks all!

  • Graber committed 8ed6187 on 8.x-2.x 
    Issue #3311552 by pookmish: Match method declarations with interface
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Fixed along with unrelated automated tests issue. Will release at the end of the week in case there are other issues discovered.

dercheffe’s picture

dercheffe
he/him
Primary language German
Location Sersheim, Germany
commented

Please release it asap. It's also blocking cron run

rajab natshah’s picture

rajab natshah
he/him
commented

Thank you, Marcin for the clean commit fix.
Philipp, Thanks for the extra tip on issues with cron jobs
Not sure if that affect search API and indexing too.

Having one extra testing round.

  • As a TEMP for more testing, add the committed fix as a quick fix patch in your root composer.json file
          "drupal/views_bulk_edit": {
        "Issue #3311552: Fix Match method declarations with interface":
        "https://git.drupalcode.org/project/views_bulk_edit/-/commit/8ed61876260de3333545151adeedc82356f84e2f.diff"
      }
  • For sure it will be removed after the release of Views Bulk Edit 2.7
heddn’s picture

heddn
Primary language English
Location Illinois
commented

No further issues encountered. Might be a good time for a release.

graber’s picture

graber commented

Thought I forgot but it's there: https://www.drupal.org/project/views_bulk_edit/releases/8.x-2.7

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.