Problem/Motivation

Let's add some first test-case which installs the stack and then verifies /ce-api/node/1 is working fine for some node

Issue fork lupus_decoupled-3311359

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

petar_basic made their first commit to this issue’s fork.

petar_basic opened merge request !10

petar_basic’s picture

petar_basic commented

Added an initial test.

petar_basic’s picture

petar_basic commented
Assigned: Unassigned » fago
petar_basic’s picture

petar_basic commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

merged so we can get started testing.

fago’s picture

fago
Primary language German
Location Vienna
commented
Assigned: fago » petar_basic
Status: Fixed » Needs work

so this is not working yet, unfortunately tests fail

fago’s picture

fago
Primary language German
Location Vienna
commented
Assigned: petar_basic » mostepaniukvm

let's do more testing!

mostepaniukvm made their first commit to this issue’s fork.

mostepaniukvm opened merge request !13

  • mostepaniukvm committed be79222 on 1.x 
    Issue #3311359 by mostepaniukvm, fago: Add initial test coverage

mostepaniukvm opened merge request !14

mostepaniukvm opened merge request !15

  • mostepaniukvm committed be79222 on 3311359-specify-dependencies 
    Issue #3311359 by mostepaniukvm, fago: Add initial test coverage
  • mostepaniukvm committed 6fd148b on 3311359-specify-dependencies
    Issue #3311359 by mostepaniukvm: Add initial test coverage
  • mostepaniukvm committed 719a779 on 3311359-specify-dependencies
    Issue #3311359 by mostepaniukvm: Specify more dependencies.
  • mostepaniukvm committed 5367034 on 3311359-specify-dependencies
    Issue #3311359 by mostepaniukvm: Add test_dependencies.

mostepaniukvm’s picture

mostepaniukvm
he/him
commented

tried more and can't make it work here. Locally tests are green when I run simply like this:
phpunit web/modules/contrib/lupus_decoupled/
or
php ./web/core/scripts/run-tests.sh --color --keep-results --suppress-deprecations --types "Simpletest,PHPUnit-Unit,PHPUnit-Kernel,PHPUnit-Functional" --concurrency "32" --repeat "1" --sqlite "sites/default/files/.ht.sqlite" --dburl "sqlite://localhost/sites/default/files/.ht.sqlite" --url "http://d9playground.localdev.space" --directory modules/contrib/lupus_decoupled

I added few more obvious tests and they works, only one that is really valuable and check /ce-api endpoint always fails.

As last tries I specified more dependencies in test itself and in .info.yml under test_dependencies but it doesn't help.
Little chance that it can start working after next tagged release as mentioned here.
https://www.drupal.org/docs/automated-testing/phpunit-in-drupal/running-...

Let's discuss on next weekly how to continue here

fago’s picture

fago
Primary language German
Location Vienna
commented

We decided that we don't want to spend much more time here, but rather invest it building up the test-pipeline on a gitlab runner.
So we could started by cloning the repo into the gitlab instance and test for free. And once working, get the opt-in on drupal.org to run gitlab tests.
Start based upon https://git.drupalcode.org/project/search_api_opensearch/-/blob/2.x/.git...

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs work » Fixed

well, initial test-coverage is there, so I'm calling this done. Next topic is automated test runs!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.