Problem/Motivation

As identified by @zenimagine, link hover effects are blue regardless of the primary color set in the Olivero theme settings.

Steps to reproduce

  1. Fresh install
  2. Change olivero primary color to a non-blue color
  3. Hover over a link
  4. Observe a blue background

CommentFileSizeAuthor
#9 3311218_8-after.png323.68 KBjavi-er
#8 3311218_8.patch4.15 KBandy-blum
#7 Screenshot from 2022-09-23 15-57-52.png113.61 KBanjali rathod
#6 3311218_6.patch191.5 KBandy-blum
#4 3311218-firefox-after.gif125.54 KBjavi-er
#4 3311218-edge-after.gif145.79 KBjavi-er
#4 3311218-chrome-mac-after.gif154.21 KBjavi-er
#4 3311218-chrome-mac-before.gif85.37 KBjavi-er
#3 Screen Shot 2022-09-22 at 4.13.23 PM.png417.64 KBandy-blum
Screen Shot 2022-09-22 at 3.41.13 PM.png418.4 KBandy-blum

Issue fork drupal-3311218

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andy-blum created an issue. See original summary.

andy-blum opened merge request !2780

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2022-09-22 at 4.13.23 PM.png417.64 KB

Link hover should now reflect the chosen primary color.

javi-er’s picture

javi-er commented
StatusFileSize
new 3311218-chrome-mac-before.gif85.37 KB
new 3311218-chrome-mac-after.gif154.21 KB
new 3311218-edge-after.gif145.79 KB
new 3311218-firefox-after.gif125.54 KB

Changes look good to me, and it's fixing the issue on 10.1.x , does this needs to be back-ported to D9?

Chrome Before

Chrome After

Firefox After

Edge After

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented

Color changing isn't in D9, so this doesn't need backported to 9. I'll make a patch for 10.0.x though so we can queue tests for it.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
StatusFileSize
new 3311218_6.patch191.5 KB

10.0.x patch

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
StatusFileSize
new Screenshot from 2022-09-23 15-57-52.png113.61 KB

thanks @andy-blum
I was trying to apply patch on Drupal Version 10.1.0-dev via composer , but getting error, please refer screenshot.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Assigned: andy-blum » Unassigned
StatusFileSize
new 3311218_8.patch4.15 KB

New patch for 10.0.x

javi-er’s picture

javi-er commented
StatusFileSize
new 3311218_8-after.png323.68 KB

Patch at #8 applies to 10.1.x correctly and fixes the issue, screenshot attached.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Status: Needs review » Reviewed & tested by the community

Per #4 and #9, RTBC

  • lauriii committed 81a05c8 on 10.1.x 
    Issue #3311218 by andy-blum, javi-er: Olivero link hover styles are not...

  • lauriii committed 1146dfa on 10.0.x 
    Issue #3311218 by andy-blum, javi-er: Olivero link hover styles are not...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 10.1.x-dev » 10.0.x-dev
Priority: Minor » Normal
Status: Reviewed & tested by the community » Fixed

Committed 81a05c8 and pushed to 10.1.x. Also cherry-picked to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.