Problem/Motivation

Dismiss button in alert is not dismissing working as it should. Replacing data-dismiss to data-bs-dismiss in https://git.drupalcode.org/project/radix/-/blob/5.0.x/src/components/ale... makes it work again
as said in https://getbootstrap.com/docs/5.0/components/alerts/#dismissing

CommentFileSizeAuthor
#4 3311179-4-after.png27.73 KBshyam_bhatt
#4 3311179-4-before.png37.33 KBshyam_bhatt
#3 3311179-3.patch522 bytes_pratik_

Issue fork radix-3311179

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aleix created an issue. See original summary.

aleix opened merge request !41

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented
Status: Active » Needs review
StatusFileSize
new 3311179-3.patch522 bytes

Here is the patch.
Thanks

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3311179-4-before.png37.33 KB
new 3311179-4-after.png27.73 KB

I have checked the "MR !41" and the "3311179-3.patch" and both are working fine. After applying patch the alert close button works fine.
Please check the below images.

Before:
2022-09-23/3311179-4-before.png

After:
2022-09-23/3311179-4-after.png

doxigo made their first commit to this issue’s fork.

doxigo’s picture

doxigo commented
Status: Reviewed & tested by the community » Fixed

Thanks again, reverted/merged as well

  • doxigo committed 4339646 on 5.0.x authored by aleix 
    Issue #3311179 by aleix, _pratik_: Dismiss button not working

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.