Problem/Motivation

At the moment tests are failing for 2.x-dev due to at least the following two errors:

  • An assertion that an object property that holds 1 === TRUE
  • WebformHandlerTest requires module path_alias to be installed

Steps to reproduce

Run phpunit against Pagedesigner's tests.

Proposed resolution

Update code to fix the errors

Remaining tasks

Patch and re-run tests

Issue fork pagedesigner-3310446

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

stefanos.petrakis created an issue. See original summary.

stefanos.petrakis opened merge request !36

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Status: Active » Needs review

Tests are green against 9.4; 9.5 would need some more work, but that would be another issue.

pvbergen’s picture

pvbergen commented

Seems like the changes are rather minor for D9.4. Let's update 2.x and add automatic testing for D9.4/PHP7.4.
I think we are RTBC on this issue.

Could you document the additional work for D9.5 in a separate issue?

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Status: Needs review » Fixed
Related issues: +#3311338: Update tests for D9.5/D10 compat and PHP >= 8

roger that, added relevant placeholder issue #3311338: Update tests for D9.5/D10 compat and PHP >= 8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.