Problem/Motivation

When signing in with the double opt-in being activated, users see a notification with the text Please check your email to confirm your subscription.. This text cannot be changed.
Also, site builders may want to remove this notification altogether; for instance, when there already is another notification configured through the Webform module.

Proposed resolution

Instead of hard-coding the string, make it a translatable configuration option.

CommentFileSizeAuthor
#6 interdiff_4-6.txt503 bytesmrshowerman
#6 3310435-make-double-opt-in-6.patch4.13 KBmrshowerman
#5 interdiff_2-4.txt479 bytesmpaulo
#4 3310435-4.patch4.06 KBmpaulo
#2 3310435-make-double-opt-in.patch4.09 KBmrshowerman

Comments

mrshowerman created an issue. See original summary.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Assigned: mrshowerman » Unassigned
Status: Active » Needs review
StatusFileSize
new 3310435-make-double-opt-in.patch4.09 KB
mpaulo’s picture

mpaulo
He/Him
commented
Assigned: Unassigned » mpaulo

Reviewing this.

mpaulo’s picture

mpaulo
He/Him
commented
Assigned: mpaulo » Unassigned
StatusFileSize
new 3310435-4.patch4.06 KB

LGTM!
mailchimp.settings.yml was missing a new line at the end of the file, so this new patch adds just it.
Keeping this in NR.

mpaulo’s picture

mpaulo
He/Him
commented
StatusFileSize
new interdiff_2-4.txt479 bytes
mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new 3310435-make-double-opt-in-6.patch4.13 KB
new interdiff_4-6.txt503 bytes

Thanks @mpaulo for reviewing!

Just realized that we should only set the new configuration setting if it hasn't been set before (e.g., when you forgot to run drush updb before saving the module's settings page).

ramonvasconcelos’s picture

ramonvasconcelos commented
Assigned: Unassigned » ramonvasconcelos

I'll take a look at the patch too.

ramonvasconcelos’s picture

ramonvasconcelos commented
Assigned: ramonvasconcelos » Unassigned
Status: Needs review » Reviewed & tested by the community

Your patch is working as proposed.

  • a7af727c committed on 2.x 
    Issue #3310435 by mrshowerman, mpaulo: Make double opt-in message...
maximumpotter’s picture

maximumpotter commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution. This will be in the next release.

  • a7af727c committed on oauth-update 
    Issue #3310435 by mrshowerman, mpaulo: Make double opt-in message...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.