FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\sitestudio_acsf\README.md
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------
10 | WARNING | Line exceeds 80 characters; contains 157 characters
12 | WARNING | Line exceeds 80 characters; contains 102 characters
18 | WARNING | Line exceeds 80 characters; contains 120 characters
----------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\sitestudio_acsf\sitestudio_acsf.install
------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
11 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
38 | WARNING | [ ] Hook implementations should not duplicate @param documentation
38 | ERROR | [ ] Missing parameter comment
38 | ERROR | [ ] Missing parameter type
39 | WARNING | [ ] Hook implementations should not duplicate @return documentation
39 | ERROR | [x] Separate the @param and @return sections by a blank line.
39 | ERROR | [ ] Description for the @return value is missing
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\sitestudio_acsf\src\Config\StylesheetJsonStorageOverride.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\sitestudio_acsf\src\SiteStudioAcsfServiceProvider.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#7 drupal-coding-standard-3310052-6.patch2.48 KBdharti patel
#2 drupal-standard-coding-issue-3310052-2.patch2.12 KBakshay.kelotra

Issue fork sitestudio_acsf-3310052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akshay.kelotra created an issue. See original summary.

akshay.kelotra’s picture

akshay.kelotra commented
Assigned: akshay.kelotra » Unassigned
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new drupal-standard-coding-issue-3310052-2.patch2.12 KB

I have fixed this issue and providing a patch. Please Review

8ballsteve made their first commit to this issue’s fork.

8ballsteve opened merge request !1

8ballsteve’s picture

8ballsteve commented

Patch looks good - thanks for the feedback and contribution!

dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel
dharti patel’s picture

dharti patel commented
Assigned: dharti patel » Unassigned
StatusFileSize
new drupal-coding-standard-3310052-6.patch2.48 KB

I've reviewed the #2 patch and after applying the patch I've faced one issue I've to resolve the issue and created a new patch for the same.
Please review the patch.

Thanks!

dipesh_goswami’s picture

dipesh_goswami
Primary language English
commented
Assigned: Unassigned » dipesh_goswami

Hi Dharti Patel,
I am reviewing your patch.
Thanks

dipesh_goswami’s picture

dipesh_goswami
Primary language English
commented
Assigned: dipesh_goswami » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi Dharti Patel,

Your patch applied cleanly (shown below):

dipes@Lucky MINGW64 /c/xampp/htdocs/dipeshdrupal/web/modules/contrib/sitestudio_acsf-3310052 (3310052-drupal-standard-coding)
$ git apply -v drupal-coding-standard-3310052-6.patch
Checking patch README.md...
Checking patch sitestudio_acsf.info.yml...
Checking patch sitestudio_acsf.install...
Applied patch README.md cleanly.
Applied patch sitestudio_acsf.info.yml cleanly.
Applied patch sitestudio_acsf.install cleanly.

dipes@Lucky MINGW64 /c/xampp/htdocs/dipeshdrupal/web/modules/contrib/sitestudio_acsf-3310052 (3310052-drupal-standard-coding)

All the phpcs issues has been fixed (shown below):

dipes@Lucky MINGW64 /c/xampp/htdocs/dipeshdrupal/web/modules/contrib (master)
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig sitestudio_acsf-3310052/

dipes@Lucky MINGW64 /c/xampp/htdocs/dipeshdrupal/web/modules/contrib (master)
$

So, moving it to RTBC & creating a MR from branch "3310052-drupal-standard-coding".
Thanks

  • dipesh_goswami committed 26d40873 on 1.0.x 
    Issue #3310052 by akshay.kelotra, 8ballsteve: Drupal standard coding...
8ballsteve’s picture

8ballsteve commented
Assigned: Unassigned » 8ballsteve
Status: Reviewed & tested by the community » Fixed

Fixed and merged into 1.0.x - thanks for the contributions here!

8ballsteve’s picture

8ballsteve commented
Status: Fixed » Closed (fixed)