Problem/Motivation

As discovered in testing #3306210: Remove Farbtastic library from core at https://www.drupal.org/pift-ci-job/2476397, currently /core/modules/ckeditor5/js/ckeditor5.js fails our JS linting, which will cause any core patch/MR changing JS-files to stop at the linting check stage of the test script.

Error: 

/var/www/html/core/modules/ckeditor5/js/ckeditor5.js
  7:1  error  Delete `⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Steps to reproduce

$ yarn run lint:core-js-passing [location_of_drupal]/core

Proposed resolution

Remove the newline on line 7 of /core/modules/ckeditor5/js/ckeditor5.js

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3309800-4.patch335 bytesspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3309800-4.patch335 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Reviewed & tested by the community

new line has been present since #3309318: Remove IE11 workaround from CKEditor 5 not sure why it didn't fail before.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
spokje’s picture

spokje
Primary language Dutch
commented

not sure why it didn't fail before.

Looks like the if-branch to trigger the JS-linting was never triggered after #3309318: Remove IE11 workaround from CKEditor 5?
No clue, just stumbled over this.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

My cross-post with @nod_ did an unwanted status change, restoring RTBC.

  • catch committed ee6aacd on 10.0.x 
    Issue #3309800 by Spokje: /core/modules/ckeditor5/js/ckeditor5.js fails...
  • catch committed c1b854c on 10.1.x
    Issue #3309800 by Spokje: /core/modules/ckeditor5/js/ckeditor5.js fails...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I think the status change was accidental. Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

spokje’s picture

spokje
Primary language Dutch
commented

(off to collect his fastest-commit-of-the-day-on-d.o. award)

nod_’s picture

nod_
Primary language French
Location Lille
commented

Follow-up for the root cause #3309807: Fix commit eslint checks following removal of es6 files

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3309807: Fix commit eslint checks following removal of es6 files

👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.