Remove Farbtastic library from core

Blocked on deprecation

IMHO the Color contributed module should add the library as its own implementation before removing from core; if not the Color module, a contrib module of its own kinda the jQueryUI modules. Image Effects has a dependency to this library, and just removing from core would raise the point of finding/implementing a replacement; I assume more contrib might end up in the same predicament.

Now postponed on #3306607: Add farbtastic library to color module because it was deprecated in core 9.5 so contrib has a replacement for this library.

Tagging

After the deletion there are three references to farbtastic left, two in the color.admin.css-files of stable and stable9.
As far as I know we keep (P)CSS files for deleted modules/libraries in themes that are nominated for deprecation/removal. Which is why the color module related CSS files are left after the deletion of the color module in the first place.

The third is in dictionary.txt from cspell and is caused by the two references explained above.

Added change record.

Thanks @quietone.

In other news: stable and stable9 are (most probably) _not_ on their way out of D10, meaning that templates/CSS files for removed modules/assets should be removed: https://drupal.slack.com/archives/C014CT1CN1M/p1662002475998399

To me it make sense to remove the left-over CSS files for the Color module (which contain the farbtastic references) in a separate issue.
Which I created here: #3307225: Remove leftover templates/CSS files from removed modules/assets from Stable 9

Love the enthusiasm, but I think technically this is still postponed on having a contrib replacement (which looks like it's going to be in the contrib color module #3306607: Add farbtastic library to color module because it was deprecated in core 9.5) and the removal of leftover templates/css/stuff from stable/stable9 (#3307225: Remove leftover templates/CSS files from removed modules/assets from Stable 9)

missing a bit in vendor-update, other than that, all good for me.

Thanks @nod, would never have spotted that.

I forgot to remove the tag when I added the CR.

I applied the MR locally and grepped for farbtastic and some instances were discovered.

git grep -i farbtastic
core/misc/cspell/dictionary.txt:farbtastic
core/themes/stable/css/color/color.admin.css:.farbtastic {
core/themes/stable9/css/color/color.admin.css:.farbtastic {

Thanks @quietone

Per #12 this one _should_ have been on Postponed on #3307225: Remove leftover templates/CSS files from removed modules/assets from Stable 9 and #3306607: Add farbtastic library to color module because it was deprecated in core 9.5. (It is now...)

Your (correct) remarks should be fixed after #3307225: Remove leftover templates/CSS files from removed modules/assets from Stable 9 lands and we throw in another yarn spellcheck:make-drupal-dict in this issue

Per @xjm.

FYI: #3307225: Remove leftover templates/CSS files from removed modules/assets from Stable 9 is RTBC. #3306607: Add farbtastic library to color module because it was deprecated in core 9.5 needs review.

Indeed, #3307225: Remove leftover templates/CSS files from removed modules/assets from Stable 9 is in!

Next up: #3306607 — needs feedback at #3306607-8: Add farbtastic library to color module because it was deprecated in core 9.5.

Opened #3309800: /core/modules/ckeditor5/js/ckeditor5.js fails JS linting for test failure in https://www.drupal.org/pift-ci-job/2476397 unrelated to this MR

MR seems complete, associated contrib issue is going well so marking this one RTBC.

The test is failing with:

/var/www/html/core/modules/ckeditor5/js/ckeditor5.js
  7:1  error  Delete `⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.


eslint: failed

… even though that file is not touched here. 🤯

EDIT: @Spokje already spotted that and opened #3309800: /core/modules/ckeditor5/js/ckeditor5.js fails JS linting for it, which was committed as we speak! 👍

Re-testing… EDIT: I can't because it's not mergeable, probably because of #3309800 🙃 I'm sure @Spokje is already pushing the merge commit that will trigger a re-test, so … doing nothing!

I'm optimistic that will come back green. Associated contrib issue is green too #3306607: Add farbtastic library to color module because it was deprecated in core 9.5

Given that the contrib issue #3306607: Add farbtastic library to color module because it was deprecated in core 9.5 is RTBC, marking this as unpostponed.

(Contrib modules of removed core modules need to catch up with core; we didn't delay committing issues that broke contrib Quick Edit either.)

The CR is stating:

To continue using farbtastic you can download it from the repository or from asset-packagist.

.

Should we mention the contrib Color module? Should we give a link to "the repository" mentioned now?

Yes, that makes sense to me as it was in core for Color.

The color module issue just got committed, so we can go ahead here.

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

I've been chatting with @Spokje and I no longer think it it necessary to add info about Color to the CR. Essentially, I missed that #3306607: Add farbtastic library to color module because it was deprecated in core 9.5 existed.

I published the CR.