In \Drupal\package_manager\Stage::require we have the comment
The packages to add as regular top-level dependencies, in the form 'vendor/name:version'.
In AutoUpdates we always send the version but I think it should work without the version. just in vendor/package format
this is needed for Project Browser in #3306722: Update Installer service to work without requiring to specify the package version
Just document that vendor/package:version or vendor/package will work
In Composer of just using a version constraint like vendor:package:8.9.0 or vendor:package:^8 you could also send "vendor:package:^8 || ^9" I am not sure if that would cause a problem because of the space.
If this does not work now with Stage lets not fix it in this issue(if need to support it all) but just document the limitations.
Other modules could extend extend stage pass other require/update comments to Composer Stager so we don't have support all cases in the MVP(or ever)
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
tedbowComment #3
phenaproxima+1 for this change.
Comment #4
phenaproximaI think this is a pretty simple change.
Right now, \Drupal\package_manager\Stage::require() says, in a couple of places in its doc comment, something like this:
The packages to add, in the form 'vendor/name:version'.I would change it to say something like:
The packages to add, with or without version constraints, e.g. `vendor/name` or `vendor/name:version`.We'll want to change it in both places, keeping the existing phrasing that makes runtime/top-level dependencies distinct from dev dependencies.
I'm also removing the tag for Project Browser integration because as far as I know, this blocks nothing; it's merely a documentation issue.
Comment #7
Theresa.GrannumComment #8
Theresa.GrannumComment #9
phenaproximaOne request, for consistency. Otherwise I think this is ready.
Comment #10
Theresa.GrannumComment #11
phenaproximaLooks great to me. Merging if tests pass.
Comment #13
phenaproximaMerged into 8.x-2.x. Thanks!
Comment #15
tedbow