Discovered by @bnjmnm in #3261163-6: Update to PostCSS 8, core.libraries.yml is out of date in 9.5.x.
In #3306182: Update to latest minor and patch versions of JavaScript dependencies (except nightwatch and cspell) we failed to run yarn vendor-update in the 9.5.x patch and so the version numbers in core.libraries.yml was not updated correctly.
Run yarn; yarn vendor-update from the core directory on 9.5.x.
Run yarn; yarn vendor-update from the core directory on 9.5.x.
Figure out if we can add a test to catch this problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3308458-2.patch | 2.43 KB | longwave |
Comments
Comment #2
longwaveComment #3
longwaveComment #4
bnjmnmCreated a followup for tests #3308489: Add yarn vendor-update to commit checks tests so we can address the critical part here.
Confirmed locally by running yarn build and confirming nothing changes as core.libraries.yml now correctly reflects the installed assets.
Comment #6
lauriiiThat's not entirely true either because we did have the actual assets updated. I think for some reason the changes for the file were missing. I thought I ran
yarn buildlocally but I guess I didn't notice the changes in the libraries.yml file because usually I'm paying attention to changes in the assets themself, not in the libraries.yml even though I should have paid attention to both when runningyarn vendor-update.Committed f74be34 and pushed to 9.5.x. Thanks!