Problem/Motivation

Discovered by @bnjmnm in #3261163-6: Update to PostCSS 8, core.libraries.yml is out of date in 9.5.x.

In #3306182: Update to latest minor and patch versions of JavaScript dependencies (except nightwatch and cspell) we failed to run yarn vendor-update in the 9.5.x patch and so the version numbers in core.libraries.yml was not updated correctly.

Steps to reproduce

Run yarn; yarn vendor-update from the core directory on 9.5.x.

Proposed resolution

Run yarn; yarn vendor-update from the core directory on 9.5.x.

Remaining tasks

Figure out if we can add a test to catch this problem.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3308458-2.patch2.43 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new2.43 KB
bnjmnm’s picture

Status: Needs review » Reviewed & tested by the community
Related issues: +#3308489: Add yarn vendor-update to commit checks tests

Created a followup for tests #3308489: Add yarn vendor-update to commit checks tests so we can address the critical part here.

Confirmed locally by running yarn build and confirming nothing changes as core.libraries.yml now correctly reflects the installed assets.

  • lauriii committed f74be34 on 9.5.x
    Issue #3308458 by longwave, bnjmnm: core.libraries.yml is out of sync in...
lauriii’s picture

Priority: Critical » Major
Status: Reviewed & tested by the community » Fixed

we failed to run yarn vendor-update in the 9.5.x patch and so the version numbers in core.libraries.yml was not updated correctly

That's not entirely true either because we did have the actual assets updated. I think for some reason the changes for the file were missing. I thought I ran yarn build locally but I guess I didn't notice the changes in the libraries.yml file because usually I'm paying attention to changes in the assets themself, not in the libraries.yml even though I should have paid attention to both when running yarn vendor-update.

Committed f74be34 and pushed to 9.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.