Problem/Motivation

Packages that need to be updated to latest minor:

Note: both cspell and nightwatch updates are handled in separate issues.
cspell: #3306441: Update to the latest cspell version (6.8.1)
nightwatch: #3306446: Update Nightwatch to 2.4.1

yarn outdated, left only minor and patch versions in, also removed cspell and nightwatch since they have their own issue.

Package                   Current Latest  
@babel/core               7.17.10 7.19.0  
@babel/preset-env         7.17.10 7.19.0  
@babel/register           7.17.7  7.18.9  
eslint                    8.14.0  8.23.0  
eslint-plugin-prettier    4.0.0   4.2.1   
jquery                    3.6.0   3.6.1   
prettier                  2.6.2   2.7.1   
stylelint                 14.8.2  14.11.0 
terser                    5.14.2  5.15.0  
terser-webpack-plugin     5.3.3   5.3.6   
underscore                1.13.3  1.13.4  
webpack                   5.72.0  5.74.0  
webpack-cli               4.9.2   4.10.0

We can't make the major version jump for tabbable in 9.5.x, since that major version dropped IE11 support. (In 10.0.x we do that jump here: #3306167: Update to tabbable v6.0.0)
We can however update to the latest patch release of the 5.3 branch which is currently 5.3.3.

So for 9.5.x there's one extra row in the above table:

Package                       Current   Latest  
tabbable                      5.3.2     5.3.3
CommentFileSizeAuthor
#35 interdiff_9x_33-35.txt1015 bytesbnjmnm
#35 interdiff_10x_33-35.txt972 bytesbnjmnm
#35 3306182-35-95x.patch888.72 KBbnjmnm
#35 3306182-35-10x.patch887.97 KBbnjmnm
#33 3306182-33-10x.patch888.2 KBbnjmnm
#33 3306182-33-95x.patch888.72 KBbnjmnm
#11 3306182-11-d10.patch1.48 MBspokje
#11 interdiff_3306182_d10_8-11.txt1.54 KBspokje
#10 interdiff_3306182_d95_8-10.txt1.01 KBspokje
#10 3306182-10-d95.patch1.47 MBspokje
#8 interdiff.txt3.55 KBlauriii
#8 3306182-8-d95.patch1.48 MBlauriii
#8 3306182-8-d10.patch1.48 MBlauriii
#5 3306182-5-d10.patch1.48 MBlauriii
#5 3306182-5-d95.patch1.47 MBlauriii

Issue fork drupal-3306182

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Update to latest minor versions of JavaScript dependencies » Update to latest minor and patch versions of JavaScript dependencies
Issue summary: View changes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3306182-5-d95.patch1.47 MB
new 3306182-5-d10.patch1.48 MB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Parent issue: » #3258933: [meta] Update JavaScript dependencies for Drupal 10
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

We should regenerate our cspell dictionary as the dictionary libraries have been updated.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3306182-8-d10.patch1.48 MB
new 3306182-8-d95.patch1.48 MB
new interdiff.txt3.55 KB

Thanks for the review! Here's a patch that updates the dictionary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented 
+++ b/core/misc/cspell/dictionary.txt
@@ -437,6 +431,7 @@ entityviewedit
+eskola

While your name is in MAINTAINERS.txt that should be ignored by the cspell config - was this a clean checkout? Not sure where this is coming from otherwise.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3306182-10-d95.patch1.47 MB
new interdiff_3306182_d95_8-10.txt1.01 KB

Ran yarn spellcheck:make-drupal-dict on a clean install of 9.5.x and again on a clean install of 10.0.x.
The fact that both runs ended up with only removals from /core/misc/cspell/dictionary.txt makes me think this went well.

Am (a bit) worried about both failures on 10.0.x on nightwatch, which is updated in this patch.
I think we might want to give that update it's own issue if this round of tests fails again.

Let's see what happens if we give the ol' "try-the-same-expect-different-results" theory a spin...

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new interdiff_3306182_d10_8-11.txt1.54 KB
new 3306182-11-d10.patch1.48 MB
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Needs work

Hmm, nightwatch failure(s) may or may not have anything to do with https://github.com/nightwatchjs/nightwatch/issues/3221

Turns out upping the nightwatch version ups the selenium-webdriver version, which makes (our current) chromedriver 98.x unsupported. #3306446-5: Update Nightwatch to 2.4.1

spokje’s picture

spokje
Primary language Dutch
commented
Title: Update to latest minor and patch versions of JavaScript dependencies » Update to latest minor and patch versions of JavaScript dependencies (except nightwatch and cspell)

Slept on it, and looking at the nightwatch test failures, I think we should split the update of that one into a separate issue.

I _think_ the cspell update might deserve a separate issue as well, since it involves updating the dictionary as well on all branches.

Which would leave this issue as the "Update to latest minor and patch versions of JavaScript dependencies (except nightwatch and cspell)" issue.

Things seems to move fast in JavaScript dependency land since the updates in the patch are already behind on some dependencies.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Version: 9.5.x-dev » 10.0.x-dev

Spokje opened merge request !2697

spokje’s picture

spokje
Primary language Dutch
commented

For the 10.0.x MR (MR!2697):

spokje’s picture

spokje
Primary language Dutch
commented
Version: 10.0.x-dev » 9.5.x-dev
spokje’s picture

spokje
Primary language Dutch
commented

Unsure if we should do something about the following warning during yarn install:

00:01:58.031 yarn install v1.22.19
00:01:58.145 [1/5] Validating package.json...
00:01:58.150 [2/5] Resolving packages...
00:01:58.757 [3/5] Fetching packages...
00:02:18.510 [4/5] Linking dependencies...
00:02:18.522 warning "@ckeditor/ckeditor5-dev-utils > ts-loader@9.3.1" has unmet peer dependency "typescript@*".
00:02:30.951 [5/5] Building fresh packages...

Maybe add a dependency on "typescript": "*" to our core/package.json? Or is this something that CKEditor itself should take care of and we should address this upstream?

Spokje opened merge request !2698

spokje’s picture

spokje
Primary language Dutch
commented

For the 9.5.x MR (MR!2698):

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented

https://github.com/webpack-contrib/terser-webpack-plugin/releases/tag/v5...

Updated both MRs, the IS and the output of both yarn-lock-diff -o old.yarn.lock -n yarn.locks.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new 3306182-33-95x.patch888.72 KB
new 3306182-33-10x.patch888.2 KB

Rebasing yarn.lock on an MR was not happening. Here are some rerolls

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work 
  1. +++ b/core/package.json
@@ -62,7 +62,7 @@
+    "@popperjs/core": "2.11.6",

    This should be ~2.11.6 I guess to allow future patch releases 🤔 

  2. +++ b/core/package.json
@@ -71,16 +71,16 @@
+    "jquery": "3.6.1",

    This should be ~3.6.1 to allow future patch releases. 

  3. +++ b/core/package.json
@@ -96,20 +96,20 @@
+    "underscore": "1.13.4",

    This should be ~1.13.4 to allow future patch releases.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Needs review
StatusFileSize
new 3306182-35-10x.patch887.97 KB
new 3306182-35-95x.patch888.72 KB
new interdiff_10x_33-35.txt972 bytes
new interdiff_9x_33-35.txt1015 bytes

Addresses #34

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

https://www.npmjs.com/package/@ckeditor/ckeditor5-dev-utils/v/30.5.0

Updated IS

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

This needs a reroll now that #3307713: Remove @ckeditor/ckeditor5-dev-utils has landed.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Updated both MRs, IS, #22 and #26.

spokje’s picture

spokje
Primary language Dutch
commented

Hidden (now) outdated patch files.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Needs work

Technically needs rebase 🤷‍♂️

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Technically needs rebase 🤷‍♂️

Pushed the "rebase"-button on both MRs whilst trying to look as technical as possible.

Tests haven't started (yet), but experience with recent GitLab hardware issues tell me that they will/can/should start within the next 5-15 minutes or so.

Putting this back on NR.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs review

Thanks @longwave for pointing out in Slack I went a bit too far with the status change, Needs Review was what I'm after.

spokje’s picture

spokje
Primary language Dutch
commented
Issue tags: -Needs reroll

And let's remove the 'Needs reroll' tag *sigh*

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

I've never seen the Gitlab rebase button actually work!

Several recent commits required this to get rebuilt a few times, but it resulted in the MRs here being easier to follow. This looks all set to me assuming the tests are green (there are a few minutes left on each run and no fails yet...)

  • lauriii committed b0b4569 on 10.1.x 
    Issue #3306182 by Spokje, bnjmnm, lauriii: Update to latest minor and...

  • lauriii committed fc425d5 on 10.0.x 
    Issue #3306182 by Spokje, bnjmnm, lauriii: Update to latest minor and...

  • lauriii committed 5866092 on 9.5.x 
    Issue #3306182 by Spokje, bnjmnm, lauriii: Update to latest minor and...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

#2697 committed b0b4569 and pushed to 10.1.x and cherry-picked to 10.0.x. #2698 committed 5866092 and pushed to 9.5.x. Thanks!

lauriii closed merge request !2697

lauriii closed merge request !2698

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Opened #3308458: core.libraries.yml is out of sync in 9.5.x as we didn't run yarn vendor-update for 9.5.x here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.