I need to replace the default pattern for the frontpage plugin (site name based) by a simple "Home", and I had to make a custom plugin, we might as well provide a "text override property" so this task is easier.
Add a simple textfield to allow overriding the text for the home link.
Adds a Text override control to the Site front page plugin that lets you change the default text (Front page of %sitename) to something else.
None.
Adds a sitemap_plugin_settings.frontpage.front_text_override configuration.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
pcambraComment #3
mparker17This sounds more like a feature request than a task, so I'm updating the category.
(I'm cleaning up old issues as part of a big review of open issues for #3425146: [Plan] Stable 8.x-2.0 release: thank you for your patience with me)
Comment #4
mparker17@pcambra, thank you for the contribution; and thank you for your patience with me (I've had a very busy 5 months!)
This looks like a good start, but I am not ready to merge it for two reasons:
front_text_overrideinstead oftext_override(i.e.: because it makes this setting's relationship to the front-page-plugin clearer)If you have the time to work on this issue, may I trouble you to make these changes, and then move this ticket back to "Needs review"? If you don't have the time to work on this issue, please let us know so that someone else can pick it up!
If you need some help writing tests, please ask in this thread, and I'll see what I can do to help.
Thank you very much!
Comment #5
mparker17Adding "Needs tests" tag.
Comment #8
tom kondaReroll patch #2 and add PHPUnit test.
I fix #text output from patch #2 because it returns TRUE when empty string compares with null coalescing operator.
Comment #9
mparker17Awesome, this looks great! Thank you @tom konda and @pcambra!
I'm going to make a very slight change to the test, but overall I think this is ready to merge!
I'm going to update the issue summary shortly so it's a little easier for people who find a link to this issue in the release notes to know what changed at-a-glance.
Comment #10
mparker17Updating the issue summary as promised.
Comment #11
mparker17Awesome, Testbot is happy, so I think this is ready to commit!
Comment #13
mparker17Merged! Thanks everyone!
I'll look into making a new release with these changes in the next few weeks! (I'm hoping to merge #3545794: Remove unused cache, max_age configuration options in SitemapSyndicateBlock and #3545858: Migrate sitemap.settings.rss_front to SitemapSyndicateBlock's configuration; test, deprecate SitemapSyndicateBlock before making a release)
Comment #14
mparker17I should also mark this issue as Fixed!
Comment #17
mparker17I've released this change in version 8.x-2.4.