Add Exception Day support for 'Current day' formatter

I'm interested in fixing this. What needs to happen here? I have trouble to wrap my head around this...

Ok, that is a bit confusing to be tbh. AFAIK that's a different case than I have. I only have exceptions, not seasons. Or is seasons going to replace exceptions alltogether?

I have been using an old path from #1998266: Add "Exception day" feature. In that patch we maintained a separate list of exception days and compare those to the days of the current and next week. This was woughly what we did back then:

  /**
    * @param array $office_hours
    * @return array
    */
   protected function handleClosedDates($office_hours) {
     $time = \Drupal::time()->getRequestTime();
     $today = (int) idate('w', $time);
     $special_opening_hours = $this->getSpecialOpeningHours();
     foreach ($office_hours as $key => $item) {
       $day = (int) $item['startday'];
       if($day == 0) {
         $day = 7;
       }
       if($day >= $today) {
         $week = 'this';
       }
       else {
         $week = 'next';
       }
       $datetime = new DrupalDateTime($day - 1 . ' day ' . $week . ' week');
       $date = $datetime->format('Y-m-d');
       if (isset($special_opening_hours[$date])) {
         if ($special_opening_hours[$date]['closed'] === '1') {
           $office_hours[$key]['closed'] = TRUE;
           $office_hours[$key]['slots'] = [];
         }
         else if (isset($special_opening_hours[$date]['from']) && isset($special_opening_hours[$date]['to'])) {
           $office_hours[$key]['slots'][0] = [
             'start' => $special_opening_hours[$date]['from'],
             'end' => $special_opening_hours[$date]['to'],
           ];
         }
       }
     }
     return $office_hours;
   }

   /**
    * @return array
    */
   protected function getSpecialOpeningHours() {
     $special_opening_hours = [];
     $field_list = $this->parent->get('field_special_opening_hours');
     foreach ($field_list as $item) {
       $entity = $item->entity;
       $special_opening_hours[$entity->get('field_date')->value] = [
         'closed' => $entity->get('field_closed')->value,
         'from' => $entity->get('field_time_from')->value,
         'to' => $entity->get('field_time_to')->value,
       ];
     }
     return $special_opening_hours;
   }

I'd take a similar approach except you know a better one.

@Raveen Thakur sorry, I don't get your MR. The commit is unrelated to this issue.

There is one remaining issue. The labels of the exception days break for me, since they rely on a timestamp. Du to the changes of my MR, the timestamp is converted to a int representing the weekday. In my opinion this is a flaw of the design per se:

The OfficeHoursItem stores the weekday as an int in the day attribute
The OfficeHoursExceptionsItem stores the timestamp of the days as an int in the same day attribute

That leads to this issue. Why don't we move the timestamp to a different attribute and use the day attribute consistently? Otherwise we have to write weird code to handle the differences between OfficeHoursItem and OfficeHoursExceptionsItem.

@johnv Thank you for your feedback and your patch! Here is a quick first review;

Your approach makes sense. I have only tested my particular use case.
There is a lot of calls to dpm()
There is uncommented code in the patch.
Is there a reason for not using the issue fork? I find it a had to review your changes without having a diff.

Also this probably needs tests.

Using MRs is actually a lot easier than using patches. I highly recommend you to try them. You can get started using the instructions right below th IS of this issue by clicking on "Show commands".

I am actually only showing the next or current open day. So yes, I don't need them and that's why I didn't experience the issues you are trying to fix with your patch.