Problem/Motivation

We removed this in 10.0.x, but it was added in 10.0.x!

f3427282f2d is the commit that removed it - we need to bring back the post update and also the test for it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3306938_1.patch1.96 KBspokje
#12 3306938+3306897.patch1.08 MBspokje

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented

It's possible the test will fail due to #3306897: Fix the 9.4.4 database dumps, if it does, then this issue should be postponed on that one I think, but we can use a patch here to verify it.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3306938.patch2.88 KB
catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new 3306938.patch2.02 KB

#3 should fail due to using the 9.3 fixture.

Updating to the 9.4 fixture, and removing the extra fixture that installs olivero because that should no longer be needed.

Got a feeling the test will fail due to #3306897: Fix the 9.4.4 database dumps, but if so we just need to wait on that issue then.

The last submitted patch, 3: 3306938.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: 3306938.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3306938-interdiff.txt827 bytes
new 3306938.patch1.96 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3306938.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Active
Related issues: +#3290810: Remove updates added prior to 9.4.0 (9.4.4 for ckeditor) and add 9.4.0 database dumps
spokje’s picture

spokje
Primary language Dutch
commented

Nice, somehow I can't restore the hidden files :/

catch’s picture

catch
he/him
Primary language English
commented
Title: Restore olivero_post_update_add_olivero_primary_color() » [PP-1] Restore olivero_post_update_add_olivero_primary_color()
Status: Active » Postponed

OK that fail is actually the right fail based on #3306897: Fix the 9.4.4 database dumps, so postponing on there.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3306938+3306897.patch1.08 MB

Seems like a good idea to validate the new 10.0.x 9.4.0-fixtures by adding those to the patch in #7.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3306938_1.patch1.96 KB

Re-uploading the patch in #7. For whatever reason I get a 403 when trying to do a retest on it from the link in #7.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Postponed » Reviewed & tested by the community

Since I only re-uploaded the existing patch without changing anything, I think I'm entitled to RTBC this.

Tests pass now the new fixtures are in, so RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Restore olivero_post_update_add_olivero_primary_color() » Restore olivero_post_update_add_olivero_primary_color()
catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Drupal 10 beta blocker

  • lauriii committed 4413ad7 on 10.1.x 
    Issue #3306938 by Spokje, catch: Restore...

  • lauriii committed 2b6be85 on 10.0.x 
    Issue #3306938 by Spokje, catch: Restore...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Confirmed that the only difference compared to what was removed in f3427282f2d is that the test is using 9.4.0 fixture instead of 9.3.0 with a custom fixture that installed Olivero.

Committed 4413ad7 and pushed to 10.1.x and cherry-picked to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.