Remove updates added prior to 9.4.0 (9.4.4 for ckeditor) and add 9.4.0 database dumps

Added a note to update system_requirements() following #3290808: Remove workspaces special casing from system_requirements() and fix versions/docs

One thing we could potentially do is remove modules we know we definitely want to deprecate (quickedit, RDF) from the 9.4.0 standard filled database dump in Drupal 10 pre-emptively.

Seeing the speed at which the current removal is going, I would advise not to take this route and fix this (issue) first and update the fixture when the removal is actually (almost) going in.

So basically: Update the fixture in each removal issue. If one gets in, that's great, we'll update "all" the other removal issues with the newly recreated fixture (with one less module in it), as we go.

Slight less red TestBot

Requirements problem
Errors found
Missing or invalid modules
The following modules are marked as installed in the core.extension configuration, but they are missing:

    aggregator
    hal

Review the suggestions for resolving this incompatibility to repair your installation, and then re-run update.php.

Missing updates for: CKEditor
The installed version of the CKEditor module is too old to update. Update to a version prior to 10.0.0 first (missing updates: ckeditor_post_update_omit_settings_for_disabled_plugins).

The rest of the test failures appear to be because we have no updates to run any more

Hmmm, don't think so, on 10.x there's no aggregator and hal any more.

Not sure what to do about the CKEditor version being too old.

@catch Not sure we ran into this before, because of the situation with Workspaces - we added workspaces_post_update_remove_association_schema_data() in 8.8.3 and did not remove it for the Drupal 9 cycle, and the upgrade tests ran from dumps from 8.8.0. See #3106666-47: Remove post updates added prior to 8.8.0

edit: though #20 points to a different problem anyway, we might still run into this when the dump is clean, let's see!

Let's see if this gets rid off all the non UpdatePathTestTrait related errors before we redo the fixtures.

Can we loose the phpcs:ignore?

By the looks of it (haven't actually run them locally to confirm) the remaining test-failures are because the updates that are being tested already ran when doing the updates from 9.3.0 => 9.4.x.

sqlite and pgsql test failures are relevant.

I (kinda) was afraid of this already...

Errors found
Database driver provided by module
Not enabled
The current database driver is provided by the module: sqlite. The module is currently not enabled. You should immediately enable the module.

How do we enable the relevant DB-specific module on Drupal CI?

Locally I work with MySQL, so I have the mysql module enabled.
Uninstalling (with drush) isn't possible:
mysql: The module 'MySQL' is providing the database driver 'mysql'.

It's present in core.extension and locale.project.
Please don't tell me we have to manually delete if from the fixture?

Instead of 3 different fixtures I find it more useful to enable all 3 drivers in one dump

I think the fixture now needs to have all three modules installed

Let's see if that works

Thanks everyone for working on this! Given #34 and the PP-1, I think we should leave this postponed, even if we're actively working on it.

Agreed with @andypost (33) and @catch (34) that a single fixture with all 3 drivers enabled is the best solution, so thanks for uploading that, @Spokje!

Glad to see we're planning to put the new fixtures into as many branches as possible. That's definitely helped during similar issues in the past.

Blocker is in. Needs trivial reroll to remove the mysql.install chunk.

Patch looks fine to me, but since I've worked on it, can't RTBC it myself.

Also:

1) It needs a 9.5.x patch/MR which includes only both the 9.4.0-fixtures. The drupal-9.4.0.filled.standard.php.gz fixture should have aggregator and hal enabled.
2) Although this patch isn't technically postponed on it, #3296112: Remove ViewsConfigUpdater::processSortFieldIdentifierUpdateHandler in combination with this issue would truly get rid of all code related to updates before 9.4.0.

I’m no release manager, but I hope we’re not planning to backport this to 9.5.x. That seems wrong. Folks should be able to update from 9.2.x directly to 9.5.x...

5. Also add the new 9.4.0 dumps to 9.5.x so that tests can more easily be backported. However 9.5.x can and should keep the 9.3.0 dumps too.

Only adding the fixtures without using them in any code seems to me like it's not interfering with updates from any version to any other version?

Disclaimer: Also not a release manager :)

Oh, slick. I didn’t actually look. 😅 yes, if it’s just the fixtures, love it. 😍

Thanks!
-Derek

Updated version and IS accordingly

Yeah, totally agree that the 9.4.0 fixtures should be back in 9.4.x, too. Sorry for the false alarm, I didn’t look at the actual patch in 42. I’ve been on my phone since early today...

Thanks y’all

Thanks for the title change. Maybe it’s too much of a PITA for committers, but any chance the commit message for the 9.x backports of this just say the “Add 9.4.0 database dumps” part of that? I predict I won’t be the only one confused and concerned if we see the “remove updates” part in the 9.x histories...

P.S. We could even split that out to a child issue if that was cleaner / easier.

O, the joy of multiple branches...

If #3281434: Update System module tests to not use Bartik and Seven lands before this one, we need to update all fixtures in this issue.
If it doesn't, we need a new issue to update all fixtures in this issue...

No interdiffs, only fixture changes.

Went through all changes, every single change makes sense. No references to the 9.3 fixture left and all tasks in IS look like they have been done. I have not scoured for possible missed updates though, but i feel that has been handled by the capable people before me.

RTBC for me.

core/themes/olivero/tests/src/Unit/OliveroHexToHslTest.php should not be removed.

Actually I can fix that on commit. The rest is fine.

Committed 6a1855c and pushed to 10.1.x. Thanks!
Committed f342728 and pushed to 10.0.x. Thanks!

Added change record

This needs a release note to explain that you have to be on Drupal 9.4.0 or later before updating to Drupal 10. I'm re-opening it for that.

Thanks, @catch. Looks great!