Problem/Motivation

The test suite is currently broken on the 8.x-1.x branch.

Steps to reproduce

Run Drupal CI test bot on the 8.x-1.x branch.

Proposed resolution

Part of the reason the test suite is broken is the Behat dependencies are in conflict with Drupal 9.4.x. Lets remove the Behat tests, which don't have anything of substance, and the corresponding dependencies, then beyond that fix remaining issues until we have a green test suite. Lets also remove the CircleCI configuration.

Remaining tasks

  • Remove CircleCI configuration
  • Remove Behat tests
  • Remove any Behat test dependencies
  • Identify and fix remaining issues with the test suite on Drupal CI until we're green

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork media_mpx-3306914

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

m4olivei created an issue. See original summary.

dakruchko made their first commit to this issue’s fork.

dakruchko opened merge request !1

dakruchko opened merge request !2

dakruchko closed merge request !2

dakruchko’s picture

dakruchko commented
Status: Active » Needs review
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Needs work

This is looking good. A couple of things:

  • Lets's remove the require-dev section from composer.json. That was needed on Github to run the tests, but Drupal CI should get us those test dependencies without having to specify them
  • By the same token, lets try removing minimum-stability and prefer-stable keys from composer.json. These are root only keys, so I don't think they are needed, or have any effect
  • Lets remove the patches.json file. That file has meaning in the context of the old drupal_tests Docker image, not in Drupal CI
  • Lets have DrupalCI run coding standards checks to make sure we get that configured correctly. See https://www.drupal.org/drupalorg/docs/drupal-ci/using-coderphpcs-in-drup.... Note that the patches.json file noted in the previous step patched core to adjust phpcs settings to ignore txt and md files (http://drupal.org/node/2867601). We'll probably have to make the same accomodation here, via Drupal CIs method
dakruchko’s picture

dakruchko commented

Did some updates. Please note that added drupal/coder version constraint (8.3.13). This is because of test runner issue introduced with coder 8.3.14 (https://www.drupal.org/project/drupalci_testbot/issues/3283978). As currently code styles checks are passing anyway, I would probably remove that constraint. In this case the phpcs job will be failing, but once the upstream issue is resolved, our phpcs job would work again. Any thoughts?

dakruchko’s picture

dakruchko commented
Status: Needs work » Needs review
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: Unassigned » m4olivei
Status: Needs review » Reviewed & tested by the community

Thanks @dakruchko! This is looking great. I think we're ready to merge here.

As currently code styles checks are passing anyway, I would probably remove that constraint. In this case the phpcs job will be failing, but once the upstream issue is resolved, our phpcs job would work again. Any thoughts?

I think what you have is great. I'd rather have the passing phpcs job that have it be failing until the Drupal.org ops team gets around to fixing it.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.