Problem/Motivation
There are inconsistencies in the social KPIs dashboard, which I’ll describe below:
1- Total users versus contributing users - the chart’s explanation describes a contributing user as someone who “created a topic or event; created a post; commented on topics; events or posts; or enrolled to an event in a given month”. However, the number of contributing users does not match the total event enrolments in the same period.
2- Total event enrolments - the chart is using the event_enrollment_field_data table to get all enrolments. However, that table holds all invitations, not only the accepted ones.
Steps to reproduce
- Use a platform that has sufficient data
- Go to the KPI analytics (admin/reports/social-kpi)
- See that both 'Contributing users' and 'Event enrolments' are off.
Proposed resolution
We should alter the queries, so they show the right data. For the event enrolments we should JOIN the field_enrolment_status table to include only the selected invites (see EventEnrollmentInterface.php from the social_event module) for the right values.
Remaining tasks
- Create the right queries
- Update the block queries on update hook
User interface changes
API changes
Data model changes
Issue fork social_kpi_lite-3306629
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
nkoporecI think this MR looks good and it makes sense that we don't include pending invites, setting as RTBC.
Comment #5
robertragas commentedMerged and release in 3.0.1